Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use rewards coordinator in get split functions #250

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

maximopalopoli
Copy link

@maximopalopoli maximopalopoli commented Jan 23, 2025

What Changed?

In get_operator_avs_split and get_operator_pi_split was being used delegation manager address to instantiate rewards coordinator. Now is used rewards coordinator's address.

Reviewer Checklist

  • New features are tested and documented
  • PR updates the changelog with a description of changes
  • PR has one of the changelog-X labels (if applies)
  • Code deprecates any old functionality before removing it

@maximopalopoli maximopalopoli marked this pull request as ready for review January 23, 2025 21:38
@MegaRedHand MegaRedHand added the changelog-fixed [changelog] PR fixes a bug label Jan 30, 2025
CHANGELOG.md Outdated Show resolved Hide resolved
crates/chainio/clients/avsregistry/src/writer.rs Outdated Show resolved Hide resolved
crates/chainio/clients/elcontracts/src/reader.rs Outdated Show resolved Hide resolved
crates/chainio/clients/elcontracts/src/reader.rs Outdated Show resolved Hide resolved
@MegaRedHand MegaRedHand added changelog-breaking [changelog] PR changes existing functionality and removed changelog-fixed [changelog] PR fixes a bug labels Jan 30, 2025
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nits

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
maximopalopoli and others added 3 commits January 31, 2025 09:23
Co-authored-by: Tomás Grüner <[email protected]>
Co-authored-by: Tomás Grüner <[email protected]>
Co-authored-by: Tomás Grüner <[email protected]>
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-breaking [changelog] PR changes existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants