ci: fix job that checks anvil state is up-to-date #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricomateo
changed the title
ricomateo
changed the title
pablodeymo
previously approved these changes
Jan 30, 2025
MegaRedHand
added a commit
that referenced
this pull request
Feb 4, 2025
### Motivation The previous CI job that checked whether the anvil state was up to date was actually not performing any comparison at all (it was mistakenly comparing empty files). Checking that the anvil state is up to date by re-generating it and comparing it with the existing one was not very practical since this approach is very time-sensitive: any difference in the timestamps generates a different state, which the CI wrongly takes as an outdated state. ### What Changed? This PR introduces the following changes in the CI: * Removes the step that compares the anvil state in the tests CI job, and simply checks that the script to generate the state works. * Adds a new job that checks whether the anvil state is updated (it runs only when the contracts change). ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Tomás Grüner <[email protected]>
MegaRedHand
added a commit
that referenced
this pull request
Feb 4, 2025
### Motivation The previous CI job that checked whether the anvil state was up to date was actually not performing any comparison at all (it was mistakenly comparing empty files). Checking that the anvil state is up to date by re-generating it and comparing it with the existing one was not very practical since this approach is very time-sensitive: any difference in the timestamps generates a different state, which the CI wrongly takes as an outdated state. ### What Changed? This PR introduces the following changes in the CI: * Removes the step that compares the anvil state in the tests CI job, and simply checks that the script to generate the state works. * Adds a new job that checks whether the anvil state is updated (it runs only when the contracts change). ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Tomás Grüner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The previous CI job that checked whether the anvil state was up to date was actually not performing any comparison at all (it was mistakenly comparing empty files).
Checking that the anvil state is up to date by re-generating it and comparing it with the existing one was not very practical since this approach is very time-sensitive: any difference in the timestamps generates a different state, which the CI wrongly takes as an outdated state.
What Changed?
This PR introduces the following changes in the CI:
Reviewer Checklist
changelog-Xlabels (if applies)