Skip to content

Commit

Permalink
Merge pull request #90 from umardevX/main
Browse files Browse the repository at this point in the history
Update .NET version in Dockerfile, devcontainer.json, GitHub Actions …
  • Loading branch information
zo0o0ot authored Oct 19, 2024
2 parents 2559b47 + 0d7ab2a commit 2c5f057
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 18 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.187.0/containers/dotnet/.devcontainer/base.Dockerfile

# [Choice] .NET version: 5.0, 3.1, 2.1
ARG VARIANT="7.0"
ARG VARIANT="8.0"
FROM mcr.microsoft.com/vscode/devcontainers/dotnet:0-${VARIANT}

# [Option] Install Node.js
Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"dockerfile": "Dockerfile",
"args": {
// Update 'VARIANT' to pick a .NET Core version: 2.1, 3.1, 5.0
"VARIANT": "7.0",
"VARIANT": "8.0",
// Options
"INSTALL_NODE": "true",
"NODE_VERSION": "lts/*",
Expand Down
28 changes: 14 additions & 14 deletions .github/workflows/dotnet5.yml
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
name: .NET 7 Build & Test
name: .NET 8 Build & Test

on:
push:
branches: [ main ]
branches: [main]
pull_request:
branches: [ main ]
branches: [main]

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Setup .NET 7
uses: actions/setup-dotnet@v1
with:
dotnet-version: 7.0.x
- name: Restore Dependencies
run: dotnet restore
- name: Build
run: dotnet build --no-restore
- name: Test
run: dotnet test --no-build --verbosity normal
- uses: actions/checkout@v2
- name: Setup .NET 8
uses: actions/setup-dotnet@v1
with:
dotnet-version: 8.0.x
- name: Restore Dependencies
run: dotnet restore
- name: Build
run: dotnet build --no-restore
- name: Test
run: dotnet test --no-build --verbosity normal
4 changes: 2 additions & 2 deletions prospect-scraper-mddb-2022.csproj
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<RootNamespace>prospect_scraper_mddb_2022</RootNamespace>
</PropertyGroup>

Expand Down

0 comments on commit 2c5f057

Please sign in to comment.