Merge Staging to Main #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christine Belzie <[email protected]>
…variable Add Public Environment Variable
…ader Fix: Add loading state for button submission
feat: add template for pull requests
docs: add a note about where commits should go
Signed-off-by: Christine <[email protected]>
Signed-off-by: Christine <[email protected]>
feat: add aria-label to input
docs: add CBID2 as a contributor for a11y
…-to-server-actions-and-util-helper-functions feat: added logic to use safeparse instead of parse
* fix: update prisma schema for coupon percent to not have a default (#176) * fix(UI/UX): fixed several UX issues for MVP 1 (#184) * fix(DevGiveaways): added space between "We're" and "giving" * fix(NeverMissADeal.tsx): added class `mb-16` for margin bottom in the `sm` breakpoint * fix(NeverMissADeal.tsx): make component more responsive chaged css to manipulate widths on containing div, text span, and subscriberform container * fix(DealPreview.tsx): add css to allow whitespace and line breaks in deal desc * docs: updated environment variable example file with defaults * fix: add revalidate to deals pages (#185) * docs: docs to fix image column generated by prisma * Update README.md * fix: accessibility of icons and add footer landmark (#192) * fix: add aria labels for icon buttons and links * fix: add aria label to search button * fix: change div to footer landmark * feat: add 16 x 9 image ratio requirement to form (#193) * feat: added a revalidate endpoint and env variable for validation secret * feat: revalidate_path_admin_options * fix: don't revalidate deals route on delete * feat: add og image to deals pages * docs: make getting started instructions clearer (#206) * docs: make instructions clearer * feat: add link to Discord community --------- Co-authored-by: Christine Belzie <[email protected]> * Bug dont show outdated deals (#204) * fix: added a filter to queries to only get deals that are not expired * refactor: got rid of unused import statement * fix: removed unused queries and added expired check to additional queries --------- Co-authored-by: jamesqquick <[email protected]> * feat: added disclaimer route and page with placeholder for text (#205) * feat: added disclaimer route and page with placeholder for text * chore: added text for disclaimer page --------- Co-authored-by: jamesqquick <[email protected]> * fix: updated the button color to be brighter (#211) Co-authored-by: James Q Quick <[email protected]> * fix: add main landmark to pages (#210) * feat: added contributor rocks link on readme (#214) * docs: clarify environment variables in example env file and readme (#216) * docs: moved setup to its own file and referenced it from readme and contributing file --------- Co-authored-by: Ryan Furrer <[email protected]> Co-authored-by: Emma Dawson <[email protected]> Co-authored-by: Chris Nowicki <[email protected]> Co-authored-by: Christine Belzie <[email protected]> Co-authored-by: klae32 <[email protected]>
…submit validation and redirect
Add link validation on url input using zod
- add filter to search to remove unapproved deals
…uild-Teach/deals-for-devs into feat_admin_deal_edit
Feat: Deal Form Validation
…devs into feat_admin_deal_edit
[FEAT] Edit Deal Page for Admins
* fix: update prisma schema for coupon percent to not have a default (#176) * fix(UI/UX): fixed several UX issues for MVP 1 (#184) * fix(DevGiveaways): added space between "We're" and "giving" * fix(NeverMissADeal.tsx): added class `mb-16` for margin bottom in the `sm` breakpoint * fix(NeverMissADeal.tsx): make component more responsive chaged css to manipulate widths on containing div, text span, and subscriberform container * fix(DealPreview.tsx): add css to allow whitespace and line breaks in deal desc * docs: updated environment variable example file with defaults * fix: add revalidate to deals pages (#185) * docs: docs to fix image column generated by prisma * Update README.md * fix: accessibility of icons and add footer landmark (#192) * fix: add aria labels for icon buttons and links * fix: add aria label to search button * fix: change div to footer landmark * feat: add 16 x 9 image ratio requirement to form (#193) * feat: added a revalidate endpoint and env variable for validation secret * feat: revalidate_path_admin_options * fix: don't revalidate deals route on delete * feat: add og image to deals pages * docs: make getting started instructions clearer (#206) * docs: make instructions clearer * feat: add link to Discord community --------- Co-authored-by: Christine Belzie <[email protected]> * Bug dont show outdated deals (#204) * fix: added a filter to queries to only get deals that are not expired * refactor: got rid of unused import statement * fix: removed unused queries and added expired check to additional queries --------- Co-authored-by: jamesqquick <[email protected]> * feat: added disclaimer route and page with placeholder for text (#205) * feat: added disclaimer route and page with placeholder for text * chore: added text for disclaimer page --------- Co-authored-by: jamesqquick <[email protected]> * fix: updated the button color to be brighter (#211) Co-authored-by: James Q Quick <[email protected]> * fix: add main landmark to pages (#210) * feat: added contributor rocks link on readme (#214) * docs: clarify environment variables in example env file and readme (#216) * docs: moved setup to its own file and referenced it from readme and contributing file * fix: extra validation on link submission * feat: deal form validation - page submission, real-time input, final submit validation and redirect * Bug no link validation (#220) Add link validation on url input using zod * Bug filter unapproved deals in search (#219) - add filter to search to remove unapproved deals * feat: added edit deal page * fix: update semantics of combobox (#225) * feat: added pending deals list and edit deal pages * feat: simplified edit deal form submission and standardized on action return type --------- Co-authored-by: Ryan Furrer <[email protected]> Co-authored-by: Emma Dawson <[email protected]> Co-authored-by: Chris Nowicki <[email protected]> Co-authored-by: Christine Belzie <[email protected]> Co-authored-by: klae32 <[email protected]>
* Fix: make overlay accessible (#230) * fix: update overlay to use native html dialog component * fix: add aria-labels to buttons inside search dialog * fix: add alert for no results for screen reader feedback * fix: update modal to use fixed positioning * feat: added generateStaticParams to use ISR with the dynamic route * feat: added getStaticProps to use ISR with the dynamic route for deals * fix: updated code and verified that the page was statically generated with a npm run build * refactor: cleaned up code * fix: removed unnecessary data and corrected others * perf: added loading states for asynchronously loaded deals * fix: missing import --------- Co-authored-by: Emma Dawson <[email protected]> Co-authored-by: klae32 <[email protected]> Co-authored-by: Chris Nowicki <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR Requirements
Descriptiongives a good representation of the changes madeIssuesection