🐛 (webhid) [NO-ISSUE]: Reconnection fixes #643
Merged
+21
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
valpinkman
force-pushed
the
chore/no-issue-device-connection-fixes
branch
from
954f302 to
5f18382
Compare
valpinkman
force-pushed
the
chore/no-issue-device-connection-fixes
branch
from
5f18382 to
d1b9fb4
Compare
Comment on lines
135
to
152
| // const p = new Promise((resolve, reject) => { | ||
| // this._pendingApduSubscription = from( | ||
| // this._device.sendReport(0, frame.getRawData()), | ||
| // ) | ||
| // .pipe( | ||
| // retry({ | ||
| // count: 3, | ||
| // delay: 500, | ||
| // }), | ||
| // ) | ||
| // .subscribe({ | ||
| // next: resolve, | ||
| // error: reject, | ||
| // }); | ||
| // }); | ||
|
|
||
| // await p; | ||
|
|
There was a problem hiding this comment.
Is this supposed to be uncommented ?
There was a problem hiding this comment.
actually it can be removed, we wanted to keep it to try stuff but we'll start later on if it's needed
valpinkman
force-pushed
the
chore/no-issue-device-connection-fixes
branch
from
d1b9fb4 to
a91ab8f
Compare
| @@ -38,6 +38,7 @@ export class WebHidDeviceConnection implements DeviceConnection { | |||
| private _sendApduSubject: Subject<ApduResponse> = new Subject(); | |||
| private readonly _logger: LoggerPublisherService; | |||
| private _pendingApdu: Maybe<Uint8Array> = Nothing; | |||
| private _pendingApduSubscription: Subscription | null = null; | |||
There was a problem hiding this comment.
This is unused, can be removed I guess
valpinkman
force-pushed
the
chore/no-issue-device-connection-fixes
branch
from
a91ab8f to
8c0ddbf
Compare
valpinkman
force-pushed
the
chore/no-issue-device-connection-fixes
branch
from
8c0ddbf to
d9ec133
Compare
ofreyssinet-ledger
approved these changes
Jan 29, 2025
mbertin-ledger
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Make sure to cancel the previous apdusubject in case of full disconnection / reconnection
❓ Context
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
🧐 Checklist for the PR Reviewers