Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LIVE-15288] Fix Lido message triggering blind signing #9120

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

[LIVE-15288] Fix Lido message triggering blind signing #9120

wants to merge 5 commits into from
+68 −2

Conversation

chrisduma-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Fixes Lido withdrawals triggering a blind sign rather than a clear sign

❓ Context

Ticket

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@chrisduma-ledger chrisduma-ledger requested review from a team as code owners February 5, 2025 12:51
@vercel Vercel
Copy link

vercel bot commented Feb 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 0:55am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 0:55am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 0:55am
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 0:55am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Feb 5, 2025
@live-github-bot live-github-bot bot removed the mobile Has changes in LLM label Feb 5, 2025
Wozacosta
Wozacosta approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@Wozacosta Wozacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wozacosta Wozacosta Wozacosta approved these changes

@adammino-ledger adammino-ledger adammino-ledger approved these changes

Assignees

@chrisduma-ledger chrisduma-ledger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisduma-ledger @Wozacosta @adammino-ledger