-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/zcash locktime txversion #9121
Open
Wozacosta
wants to merge
14
commits into
develop
Choose a base branch
from
fix/zcash-locktime-txversion
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
live-github-bot
bot
added
the
ledgerjs
Has changes in the ledgerjs open source libs
label
Feb 5, 2025
Wozacosta
force-pushed
the
fix/zcash-locktime-txversion
branch
from
February 6, 2025 05:41
69ed7fa
to
8eabb34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE 06 feb.: Zcash 2.3.1 is available on P4 provider for all devices.
✅ Ensures NU5 and NU6 transactions are properly supported and signed.
✅ Fixes issues with missing block height in transaction inputs.
✅ Aligns Ledger Live libraries (hw-app-btc, coin-bitcoin) with [Ledger's Zcash app]((LedgerHQ/app-zcash@develop...LedgerHQ:app-zcash:fix/apa/nu5_utxo_retrocompatibility)
✅ Checklist
npx changeset
was attached.📝 Description
1. Support for Zcash NU6 (in hw-app-btc)
ZCASH_NU6_ACTIVATION_HEIGHT
= 2726400 in constants.ts.getZcashTransactionVersion(blockHeight: number | undefined)
andgetDefaultVersions
2. Handling Block Height in Inputs
Expanded input tuple format:
Before: [Transaction, number, string | null | undefined, number | null | undefined]
After: [Transaction, number, string | null | undefined, number | null | undefined, number | null | undefined]
Changes in multiple files:
signer.ts, wallet.ts, xpub.ts, and BtcNew.ts all updated to pass block height information.
3. Tests for Zcash Transactions
New test suite added:
xpub.txs.zcash.integration.test.ts tests block height inclusion in transactions.
createTransaction.test.ts covers Zcash NU5 and NU6 transactions. Checking for correct apdus being sent
4. Zcash Ledger App Updates
transaction_parse() now correctly detects the zcash transaction version and hashes it as appropriately.
❓ Context
🧐 Checklist for the PR Reviewers