Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QAA][DETOX][SPECULOS] - Adding e2e delegation tests - CELO & TEZOS #9125

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[QAA][DETOX][SPECULOS] - Adding e2e delegation tests - CELO & TEZOS #9125

wants to merge 2 commits into from
+226 −29

Conversation

VicAlbr
Copy link
Contributor

@VicAlbr VicAlbr commented Feb 5, 2025 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

  • Adding e2e lock test for CELO
  • Adding e2e delegation tez for TEZOS

https://github.com/user-attachments/assets/e43dd6cd-df86-4ad7-ab7b-3a3af7799c3e
https://github.com/user-attachments/assets/fe742e33-ed6b-4830-8e6e-7e11c3be9c1b

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Feb 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 1:08pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 1:08pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 1:08pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 1:08pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Feb 5, 2025
@VicAlbr VicAlbr marked this pull request as ready for review February 5, 2025 16:28
@VicAlbr VicAlbr requested review from a team as code owners February 5, 2025 16:28
@VicAlbr VicAlbr enabled auto-merge February 5, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesan thesan thesan approved these changes

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger approved these changes

@abdurrahman-ledger abdurrahman-ledger abdurrahman-ledger approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@VicAlbr VicAlbr

Labels
mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VicAlbr @thesan @ypolishchuk-ledger @abdurrahman-ledger