Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (lld): add data tracking in the onboarding flow #9132

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat (lld): add data tracking in the onboarding flow #9132

wants to merge 1 commit into from
+189 −3

Conversation

fAnselmi-Ledger
Copy link
Contributor

@fAnselmi-Ledger fAnselmi-Ledger commented Feb 6, 2025 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Added tracking in the onboarding flow

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Feb 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 2:48pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 2:48pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 2:48pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 2:48pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Feb 6, 2025
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/live-15747-data-tracking-in-the-onboarding-flow branch 2 times, most recently from 6ae29a9 to af4c52b Compare February 6, 2025 14:30
@fAnselmi-Ledger fAnselmi-Ledger marked this pull request as ready for review February 6, 2025 15:02
@fAnselmi-Ledger fAnselmi-Ledger requested review from a team as code owners February 6, 2025 15:02
jiyuzhuang
jiyuzhuang previously approved these changes Feb 7, 2025
View reviewed changes
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/live-15747-data-tracking-in-the-onboarding-flow branch from af4c52b to 645703b Compare February 7, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiyuzhuang jiyuzhuang jiyuzhuang left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@fAnselmi-Ledger fAnselmi-Ledger

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fAnselmi-Ledger @jiyuzhuang