Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LIVE-16732): Swipe right gesture navigates back on swap #9136

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ejaycoleman
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Adds a swipe right gesture on the Swap app to navigate back to the home page.

Kapture 2025-02-06 at 14 52 23

❓ Context

  • JIRA or GitHub link:

LIVE-16732


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 0:57am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 0:57am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 0:57am
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 0:57am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Feb 6, 2025
@ejaycoleman ejaycoleman marked this pull request as ready for review February 7, 2025 10:00
@ejaycoleman ejaycoleman requested a review from a team as a code owner February 7, 2025 10:00
Copy link
Contributor

@Justkant Justkant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello
Thanks for the PR but I don't think this is the correct way to go about implementing this
The view already supports this with react-navigation and we need to make it work properly depending on allowsBackForwardNavigationGestures boolean used for the webview itself
Could you look at the screen used for this page instead and check if we didn't disable something here plz ?

@ejaycoleman
Copy link
Contributor Author

@Justkant I had initially gone down that route, but concluded it was the parent tab view component which was overriding the gesture. There was a thread about people discussing a similar issue here: react-navigation/react-navigation#11245

@ejaycoleman ejaycoleman requested a review from a team as a code owner February 10, 2025 12:56
@Justkant
Copy link
Contributor

Justkant commented Feb 10, 2025

@Justkant I had initially gone down that route, but concluded it was the parent tab view component which was overriding the gesture. There was a thread about people discussing a similar issue here: react-navigation/react-navigation#11245

@ejaycoleman So you mean that the tabs used in the view for the swap is overriding or cause an issue with the gesture ?
If you only do it for the swap page it's fine I suppose but I would look into a proper fix with tab view if possible

Edit: interesting comment that suggest to patch the package for react-native-tab-view react-navigation/react-navigation#11245 (comment)
Maybe we can find some updates on this too as it dates back 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants