-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(LIVE-16732): Swipe right gesture navigates back on swap #9136
base: develop
Are you sure you want to change the base?
feat(LIVE-16732): Swipe right gesture navigates back on swap #9136
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ 4 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello
Thanks for the PR but I don't think this is the correct way to go about implementing this
The view already supports this with react-navigation and we need to make it work properly depending on allowsBackForwardNavigationGestures
boolean used for the webview itself
Could you look at the screen used for this page instead and check if we didn't disable something here plz ?
@Justkant I had initially gone down that route, but concluded it was the parent tab view component which was overriding the gesture. There was a thread about people discussing a similar issue here: react-navigation/react-navigation#11245 |
@ejaycoleman So you mean that the tabs used in the view for the swap is overriding or cause an issue with the gesture ? Edit: interesting comment that suggest to patch the package for |
β Checklist
npx changeset
was attached.π Description
Adds a swipe right gesture on the Swap app to navigate back to the home page.
β Context
LIVE-16732
π§ Checklist for the PR Reviewers