Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: re-introduce SpamTX filtering #9138

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

bugfix: re-introduce SpamTX filtering #9138

wants to merge 1 commit into from

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Feb 6, 2025 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Filtering TX operations for NFTs

📝 Description

Screenshot 2025-02-07 at 10 42 45
Screen.Recording.2025-02-05.at.16.32.24.mov

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Feb 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 4:31pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 4:31pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 4:31pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 4:31pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs labels Feb 6, 2025
mcayuelas-ledger
mcayuelas-ledger commented Feb 6, 2025
View reviewed changes
apps/ledger-live-desktop/src/renderer/components/OperationsList/components/OperationWrapper.tsx
Comment on lines +25 to +26
const spamFilteringTxFeature = useFeature("spamFilteringTx");
const nftsFromSimplehashFeature = useFeature("nftsFromSimplehash");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if maybe we need to change and replace this by a new FF ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mcayuelas-ledger mcayuelas-ledger

Labels
desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mcayuelas-ledger