Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ’„ (llm) networks selection screen #9150

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Feb 7, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • network selection screen in add account flow

πŸ“ Description

Reorder the networks displayed so they are in the alphabetical order.
The network where there is already some accounts will remain at the top (ordered too)
First there is a sort depending on the number of accounts on the network
If there is the same number of accounts then we sort them alphabetically

Also fix bottom banner

Before After
image image

image

bottom banner (I forced the banner so it re appears every time for the video)

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-02-07.at.18.16.08.mp4

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner February 7, 2025 16:10
Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 5:33pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 5:33pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 5:33pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 5:33pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Feb 7, 2025
@live-github-bot live-github-bot bot removed desktop Has changes in LLD mobile Has changes in LLM labels Feb 7, 2025
@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Feb 7, 2025
@LucasWerey LucasWerey marked this pull request as draft February 7, 2025 16:13
@LucasWerey LucasWerey marked this pull request as ready for review February 7, 2025 16:37
@LucasWerey LucasWerey enabled auto-merge February 7, 2025 16:43
@LucasWerey LucasWerey disabled auto-merge February 7, 2025 17:17
@LucasWerey LucasWerey enabled auto-merge February 7, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant