fix(llm,lld): improve Solana scan accounts performances #9512

francois-guerin-ledger · 2025-03-13T08:38:15Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- ...

📝 Description

The scan account operation for Solana is particularly slow in Ledger Live. One reason is that quite a lot of HTTP requests are done sequentially to list token and staking accounts, as well as fetching all the transactions.
This PR focuses on re-writing this part, grouping RPC requests together or running them asynchronously when possible.

❓ Context

JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2025-03-13T08:38:22Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web-tools	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 21, 2025 5:27pm

3 Skipped Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	Mar 21, 2025 5:27pm
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Mar 21, 2025 5:27pm
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Mar 21, 2025 5:27pm

Justkant · 2025-03-17T15:57:55Z

libs/coin-modules/coin-solana/src/api/chain/stake-activation/rpc.ts

+    );
+  });
+
+  return compact(stakes);


I think we could do this without lodash but I don't really mind using it here

Suggested change

return compact(stakes);

return stakes.filter(Boolean);

It won't work as is, since Boolean is no predicate. Better keeping it to avoid extra boilerplate in my opinion.

Justkant · 2025-03-17T16:01:14Z

libs/coin-modules/coin-solana/src/api/chain/stake-activation/rpc.ts

+  const rawStakeAccounts = await api.getStakeAccountsByWithdrawAuth(mainAccountAddress);
+
+  if (!rawStakeAccounts.length) return [];
+
+  const sysvarStakeHistoryAccount = await api.getAccountInfo(
+    SYSVAR_STAKE_HISTORY_PUBKEY.toBase58(),
+  );
+  if (
+    !sysvarStakeHistoryAccount ||
+    !("parsed" in sysvarStakeHistoryAccount.data) ||
+    !("info" in sysvarStakeHistoryAccount.data.parsed)
+  )
+    throw new Error("StakeHistory not found");
+
+  const sysvarStakeHistoryAccountInfo = sysvarStakeHistoryAccount.data.parsed.info;
+  const stakeHistory = Array.isArray(sysvarStakeHistoryAccountInfo)
+    ? sysvarStakeHistoryAccountInfo.filter(isHistoryEntry).map(e => ({
+        epoch: BigNumber(e.epoch),
+        effective: BigNumber(e.stakeHistory.effective),
+        activating: BigNumber(e.stakeHistory.activating),
+        deactivating: BigNumber(e.stakeHistory.deactivating),
+      }))
+    : [];
+
+  const { epoch } = await api.getEpochInfo();


We should probably keep the promise.all on the 3 calls getStakeAccountsByWithdrawAuth, getAccountInfo and getEpochInfo as it was done before, wdyt ?

I actually didn't do it in order to save useless calls to the network (if getStakeAccountsByWithdrawAuth does not return any stake account, no need to call neither getAccountInfo nor getEpochInfo).

Justkant · 2025-03-17T16:08:14Z

libs/coin-modules/coin-solana/src/synchronization.ts

+  const nextSubAccs: TokenAccount[] = await Promise.all(
+    accountsWithTransactions.map(account => {


Nice, looks like you're already doing the parallel calls we talked about today for the sub accounts
The only drawback maybe here is that we don't limit the number of concurrent promises

Justkant · 2025-03-17T16:09:28Z

libs/coin-modules/coin-solana/src/synchronization.ts

+  const {
+    value: balanceValue,
+    context: { slot: blockHeight },
+  } = await api.getBalanceAndContext(address);
+  const balance = new BigNumber(balanceValue);
+
+  const tokenAccountsRaw = (await api.getParsedTokenAccountsByOwner(address)).value;
+  const token2022AccountsRaw = coinConfig.getCoinConfig().token2022Enabled
+    ? (await api.getParsedToken2022AccountsByOwner(address)).value
+    : [];
+  const tokenAccounts = [...tokenAccountsRaw, ...token2022AccountsRaw].map(toTokenAccountWithInfo);
+
+  const stakes = await getStakeAccounts(api, address);


We could also probably do those calls in parallel too

Justkant · 2025-03-17T16:10:11Z

libs/coin-modules/coin-solana/src/synchronization.ts

+    descriptors: Array<TransactionDescriptor>;
+  }>
+> {
+  // TODO: before merging, rebase this PR on https://github.com/LedgerHQ/ledger-live/pull/9480 once CI is green, and use `ky` instead of `fetch`


Do we still want to wait for the other PR ?

I've just merged the other PR 🙂

Justkant · 2025-03-17T16:15:08Z

libs/coin-modules/coin-solana/src/synchronization.ts

+    .map(account =>
+      account && "parsed" in account.data ? tryParseAsMintAccount(account.data) : undefined,
+    )
+    .map(mintInfo => (mintInfo && !(mintInfo instanceof Error) ? mintInfo.extensions : undefined));


We could probably do a single map instead of 2 here, wdyt ?

sonarqubecloud · 2025-03-21T17:38:26Z

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

github-actions bot assigned francois-guerin-ledger Mar 13, 2025

francois-guerin-ledger force-pushed the fix/LIVE-17491-improve-solana-performances branch from 4bc6d0d to db18121 Compare March 13, 2025 08:57

vercel bot deployed to Preview – web-tools March 13, 2025 09:00 View deployment

francois-guerin-ledger force-pushed the fix/LIVE-17491-improve-solana-performances branch from db18121 to 6fe69e6 Compare March 13, 2025 09:12

vercel bot deployed to Preview – web-tools March 13, 2025 09:18 View deployment

francois-guerin-ledger force-pushed the fix/LIVE-17491-improve-solana-performances branch from 6fe69e6 to a6fa77f Compare March 13, 2025 10:12

vercel bot deployed to Preview – web-tools March 13, 2025 10:13 View deployment

francois-guerin-ledger force-pushed the fix/LIVE-17491-improve-solana-performances branch from a6fa77f to 2b2b3ac Compare March 13, 2025 12:01

francois-guerin-ledger changed the base branch from develop to bugfix/LIVE-17003 March 13, 2025 12:01

vercel bot deployed to Preview – web-tools March 13, 2025 12:05 View deployment

francois-guerin-ledger force-pushed the fix/LIVE-17491-improve-solana-performances branch from 2b2b3ac to d34c102 Compare March 13, 2025 22:36

live-github-bot bot added desktop Has changes in LLD ui Has changes in the design system library translations Translation files have been touched labels Mar 13, 2025

vercel bot deployed to Preview – web-tools March 13, 2025 22:41 View deployment

francois-guerin-ledger changed the base branch from bugfix/LIVE-17003 to develop March 13, 2025 22:59

francois-guerin-ledger force-pushed the fix/LIVE-17491-improve-solana-performances branch from d34c102 to bed6385 Compare March 14, 2025 08:35

live-github-bot bot removed desktop Has changes in LLD ui Has changes in the design system library translations Translation files have been touched labels Mar 14, 2025

vercel bot deployed to Preview – web-tools March 14, 2025 08:39 View deployment

francois-guerin-ledger force-pushed the fix/LIVE-17491-improve-solana-performances branch from bed6385 to 9cf2238 Compare March 14, 2025 09:06

francois-guerin-ledger marked this pull request as ready for review March 14, 2025 09:06

francois-guerin-ledger requested a review from a team as a code owner March 14, 2025 09:06

vercel bot deployed to Preview – web-tools March 14, 2025 09:08 View deployment

Justkant reviewed Mar 17, 2025

View reviewed changes

francois-guerin-ledger force-pushed the fix/LIVE-17491-improve-solana-performances branch from 9cf2238 to 9284a65 Compare March 18, 2025 00:50

vercel bot deployed to Preview – web-tools March 18, 2025 00:55 View deployment

francois-guerin-ledger force-pushed the fix/LIVE-17491-improve-solana-performances branch from 9284a65 to df94c72 Compare March 18, 2025 00:56

vercel bot deployed to Preview – web-tools March 18, 2025 01:00 View deployment

francois-guerin-ledger force-pushed the fix/LIVE-17491-improve-solana-performances branch from df94c72 to 5ffb3a8 Compare March 18, 2025 11:58

vercel bot deployed to Preview – web-tools March 18, 2025 12:02 View deployment

francois-guerin-ledger force-pushed the fix/LIVE-17491-improve-solana-performances branch from 5ffb3a8 to 66fd28b Compare March 18, 2025 13:49

vercel bot deployed to Preview – web-tools March 18, 2025 13:53 View deployment

francois-guerin-ledger requested a review from Justkant March 18, 2025 14:38

francois-guerin-ledger force-pushed the fix/LIVE-17491-improve-solana-performances branch from 66fd28b to 4f271fd Compare March 18, 2025 21:04

vercel bot deployed to Preview – web-tools March 18, 2025 21:09 View deployment

Justkant previously approved these changes Mar 21, 2025

View reviewed changes

fix(llm,lld): improve Solana scan accounts performances

eb1c438

francois-guerin-ledger dismissed Justkant’s stale review via eb1c438 March 21, 2025 17:11

francois-guerin-ledger force-pushed the fix/LIVE-17491-improve-solana-performances branch from 4f271fd to eb1c438 Compare March 21, 2025 17:11

vercel bot deployed to Preview – web-tools March 21, 2025 17:27 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(llm,lld): improve Solana scan accounts performances #9512

fix(llm,lld): improve Solana scan accounts performances #9512

francois-guerin-ledger commented Mar 13, 2025 •

edited

Loading

vercel bot commented Mar 13, 2025 •

edited

Loading

Justkant Mar 17, 2025

francois-guerin-ledger Mar 18, 2025

Justkant Mar 17, 2025

francois-guerin-ledger Mar 18, 2025

Justkant Mar 17, 2025 •

edited

Loading

Justkant Mar 17, 2025

Justkant Mar 17, 2025

Justkant Mar 17, 2025

Justkant Mar 17, 2025

sonarqubecloud bot commented Mar 21, 2025

		const nextSubAccs: TokenAccount[] = await Promise.all(
		accountsWithTransactions.map(account => {

fix(llm,lld): improve Solana scan accounts performances #9512

Are you sure you want to change the base?

fix(llm,lld): improve Solana scan accounts performances #9512

Conversation

francois-guerin-ledger commented Mar 13, 2025 • edited Loading

✅ Checklist

📝 Description

❓ Context

🧐 Checklist for the PR Reviewers

vercel bot commented Mar 13, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Justkant Mar 17, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Mar 21, 2025

Quality Gate failed

francois-guerin-ledger commented Mar 13, 2025 •

edited

Loading

vercel bot commented Mar 13, 2025 •

edited

Loading

Justkant Mar 17, 2025 •

edited

Loading