Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: aptos token transaction bot specs #9548

Draft
wants to merge 9 commits into
base: feat/aptos-token-integration
Choose a base branch
from

Conversation

semeano
Copy link
Contributor

@semeano semeano commented Mar 17, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Bot specs for Aptos token transaction.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Mar 17, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Mar 21, 2025 5:45pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2025 5:45pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2025 5:45pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2025 5:45pm

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required β‰₯ 80%)
7.0% Duplication on New Code (required ≀ 3%)

See analysis details on SonarQube Cloud

@semeano semeano changed the base branch from develop to feat/aptos-token-integration March 19, 2025 08:00
@semeano semeano force-pushed the test/aptos-token-bot-specs branch from 42211e5 to 39edc6e Compare March 19, 2025 08:06
@live-github-bot live-github-bot bot removed common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Mar 19, 2025
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Mar 19, 2025

Desktop Bundle Checks

Comparing 9eda8ab against 0c54ada.

πŸš€ renderer bundle size decreased (39.7mb -> 38.5mb). Thanks ❀️
⚠️ elliptic library is now duplicated in renderer (regression)
πŸš€ @ledgerhq/hw-app-eth library is no longer duplicated in renderer

Mobile Bundle Checks

Comparing 9eda8ab against 0c54ada.

πŸš€ main.ios.jsbundle bundle size decreased (63.9mb -> 62.5mb). Thanks ❀️
πŸš€ main.android.jsbundle bundle size decreased (63.9mb -> 62.5mb). Thanks ❀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant