Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ‘· SonarCloud PR Analysis Improvements #9580

Draft
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Mar 18, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Rework the way we run the sonarcloud PR analysis to make it more generic and reuse the steps already done in the master workflow. This will allow us to run the coverage analysis of our libs and set this job as required before merging.
This is done to ensure the good quality of our codebase.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Mar 18, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2025 3:05pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2025 3:05pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2025 3:05pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2025 3:05pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM automation CI/CD stuff labels Mar 18, 2025
@cgrellard-ledger cgrellard-ledger changed the title πŸ‘· support: rework sonar pr analysis πŸ‘· SonarCloud PR Analysis Improvements Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD stuff desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant