Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buggfix: '-' with neutral color displayed for 0% variation in market and asset list #9581

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Buggfix: '-' with neutral color displayed for 0% variation in market and asset list #9581

wants to merge 2 commits into from
+35 −13

Conversation

RobinVncnt
Copy link
Contributor

@RobinVncnt RobinVncnt commented Mar 18, 2025 •
edited by jira bot
Loading

✅ Checklist

  • [ x] npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

buggfix: '-' with neutral color displayed for 0% variation in market and asset list

❓ Context

Screenshot 2025-03-11 at 15 15 41

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@RobinVncnt
Neutral color and no arrow displayed for 0% variation in market list …
de7d4db 
…on LLM

'-' in neutral color displayed for 0% variation in market and asset  list on LLM

'-' in neutral color displayed for 0% variation in market and asset  list on LLM

add correct neutral color

bracket deleted in props and '-' added in market

replace '-' by −

Neutral color and no arrow displayed for 0% variation in market list on LLM

add correct neutral color
@RobinVncnt
bracket deleted in props and '-' added in market
ca38fa4
@RobinVncnt RobinVncnt requested a review from a team as a code owner March 18, 2025 15:26
@vercel Vercel
Copy link

vercel bot commented Mar 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 3:29pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Mar 18, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
38.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

Assignees

@RobinVncnt RobinVncnt

Labels
mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobinVncnt @mcayuelas-ledger