Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/live 17628 alert local banner recover #9582

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

mitchellv-ledger
Copy link
Contributor

@mitchellv-ledger mitchellv-ledger commented Mar 18, 2025 β€’

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Warning banner updated to use warning color and new warning rounded fill icon when user has paid but not finished setup so is not protected. Also removed description from recover banner on mobile as the text was being ellipsed.

On Desktop:
Screenshot 2025-03-18 at 15 43 05

On mobile:
Screenshot 2025-03-18 at 16 14 23

Screenshot 2025-03-18 at 16 10 47

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Sorry, something went wrong.

@mitchellv-ledger mitchellv-ledger added desktop Has changes in LLD mobile Has changes in LLM labels Mar 18, 2025
@mitchellv-ledger mitchellv-ledger self-assigned this Mar 18, 2025
@mitchellv-ledger mitchellv-ledger requested a review from a team as a code owner March 18, 2025 15:43
Copy link

vercel bot commented Mar 18, 2025 β€’

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2025 9:35am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2025 9:35am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2025 9:35am
web-tools ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2025 9:35am

@live-github-bot live-github-bot bot added the translations Translation files have been touched label Mar 18, 2025
@mitchellv-ledger mitchellv-ledger marked this pull request as draft March 18, 2025 15:57
@mitchellv-ledger mitchellv-ledger marked this pull request as ready for review March 19, 2025 14:28
@mitchellv-ledger mitchellv-ledger force-pushed the feat/LIVE_17628_alert_local_banner_recover branch 2 times, most recently from 1db0819 to d268f54 Compare March 21, 2025 09:17
@mitchellv-ledger mitchellv-ledger requested a review from a team March 24, 2025 17:46
@@ -0,0 +1,6 @@
---
"ledger-live-desktop": patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"ledger-live-desktop": patch
"ledger-live-desktop": minor

@@ -0,0 +1,6 @@
---
"ledger-live-desktop": patch
"live-mobile": patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"live-mobile": patch
"live-mobile": minor

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required β‰₯ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants