Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (llm-ios) animated launchscreen swift module #9592

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Mar 19, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • IOS modules
    • Splashscreen

πŸ“ Description

This PR aims to create a custom swift module to handle the animated launchscreen on ios. This way we will be able to dismiss it from react-native part.

We need to trick a bit the native behaviour by removing the logo on the LaunchScreen and to display a view with the gif on it since native LaunchScreen only accepts static images.

The new animated splashscreen will run a gif directly. We will dismiss it once the main part of the app is rendered to avoid white / black screen. Also to avoid to have only half of the animation we ensure that the gif has been played at least once

=> I've reformatted a bit the appDelegate to follow xcode formatting

The main issue is with detox. We sometimes had duplicated WS connection. TO avoid this the custom splashscreen and loading view are hidden using launchArgs and BOOL isDetox = [[[NSProcessInfo processInfo] arguments] containsObject:@"-IS_TEST"];
All of the UI decisions have been validated by design team ! See bellow a video on multiple ios devices

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2025 2:03pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2025 2:03pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2025 2:03pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2025 2:03pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Mar 19, 2025
@LucasWerey LucasWerey force-pushed the feat/LIVE-17159 branch 7 times, most recently from 5a0336b to fc6e1cc Compare March 20, 2025 18:00
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required β‰₯ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant