Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sol staking delegate from-address #9602

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Canestin
Copy link
Contributor

@Canestin Canestin commented Mar 20, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Problem

When staking Solana on LLM, the Nano X may disconnect at step 2 of 3 while confirming the transaction. After reconnecting, the "Delegate From" address shown on LLM changes, while the address on the Nano X remains the same, causing a mismatch.

Solution

Avoid updating the transaction when one is already prepared for the stake.createAccount SOL action.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Canestin Canestin requested a review from a team as a code owner March 20, 2025 08:57
Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Mar 21, 2025 6:36pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2025 6:36pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2025 6:36pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2025 6:36pm

add changeset

fix: sol staking delegate from-address
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required β‰₯ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants