Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aptos cal #9629

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Update aptos cal #9629

merged 1 commit into from
Mar 24, 2025

Conversation

may01
Copy link
Contributor

@may01 may01 commented Mar 23, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

remove native APT curency from tokens list.
Add 2 missing coins:

  • whWETH
  • ANI

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@may01 may01 requested a review from a team as a code owner March 23, 2025 11:43
Copy link

vercel bot commented Mar 23, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Mar 23, 2025 11:49am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Mar 23, 2025 11:49am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 23, 2025 11:49am
react-ui-storybook ⬜️ Ignored (Inspect) Mar 23, 2025 11:49am

@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Mar 23, 2025
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Mar 23, 2025

Desktop Bundle Checks

Comparing c449f7d against 673d290.

πŸš€ renderer bundle size decreased (39.7mb -> 38.5mb). Thanks ❀️
⚠️ elliptic library is now duplicated in renderer (regression)
πŸš€ @ledgerhq/hw-app-eth library is no longer duplicated in renderer

Mobile Bundle Checks

Comparing c449f7d against 673d290.

πŸš€ main.ios.jsbundle bundle size decreased (63.9mb -> 62.5mb). Thanks ❀️
πŸš€ main.android.jsbundle bundle size decreased (63.9mb -> 62.5mb). Thanks ❀️

@may01 may01 merged commit 79ccf44 into feat/aptos-token-integration Mar 24, 2025
55 of 56 checks passed
@may01 may01 deleted the feat/update-aptos-cal branch March 24, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants