Skip to content

Commit

Permalink
refactor: 🔥 remove color reset text i18n, add confirmText prop in col…
Browse files Browse the repository at this point in the history
…or_popover
  • Loading branch information
Leecason committed Mar 22, 2020
1 parent 4ed178b commit aa92558
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 11 deletions.
6 changes: 3 additions & 3 deletions src/components/MenuCommands/ColorPopover.vue
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
class="color-hex__button"
@click="confirmColor(color)"
>
ok
{{ confirmText }}
</el-button>
</div>

Expand Down Expand Up @@ -99,9 +99,9 @@ export default class ColorPopover extends Vue {
@Prop({
type: String,
default: '',
default: 'OK',
})
readonly resetButtonText!: string;
readonly confirmText!: string; // TODO: i18n ?
private color: string = '';
private popoverVisible: boolean = false;
Expand Down
2 changes: 0 additions & 2 deletions src/i18n/en/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,9 @@ export default {
},
TextColor: {
tooltip: 'Text color',
reset: 'Clear',
},
TextHighlight: {
tooltip: 'Text highlight',
reset: 'Transparent',
},
LineHeight: {
tooltip: 'Line height',
Expand Down
2 changes: 0 additions & 2 deletions src/i18n/pl/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,9 @@ export default {
},
TextColor: {
tooltip: 'Kolor tekstu',
reset: 'Wyczyść',
},
TextHighlight: {
tooltip: 'Podświetlenie tekstu',
reset: 'Przezroczysty',
},
LineHeight: {
tooltip: 'Wysokość linii',
Expand Down
2 changes: 0 additions & 2 deletions src/i18n/ru/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,9 @@ export default {
},
TextColor: {
tooltip: 'Цвет текста',
reset: 'Очистить',
},
TextHighlight: {
tooltip: 'Цвет выделения текста',
reset: 'Нет цвета',
},
LineHeight: {
tooltip: 'Интервал',
Expand Down
2 changes: 0 additions & 2 deletions src/i18n/zh/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,9 @@ export default {
},
TextColor: {
tooltip: '文本颜色',
reset: '清除',
},
TextHighlight: {
tooltip: '文本高亮',
reset: '透明',
},
LineHeight: {
tooltip: '行距',
Expand Down

0 comments on commit aa92558

Please sign in to comment.