-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registry API (Sync) V2 #186
Draft
thecatcore
wants to merge
5
commits into
main
Choose a base branch
from
feature/registry-sync-v2/main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial work on registry-sync-v2 * More progress on registry api v2 - differentiate "synced" Index-Key-Value registries from simple Key-Value registries - start preparing registry remapping * Start working on new registry remapper * Rename some classes * Port remapping system to v2 and port to every supported version * Ensure backward compatibility with registry-sync-api-v1 * Fix a few possible crashes when using registries * Add more useful methods to RegistryHelper * Make vanilla registries first assignable id 1 instead of 0 * Some improvements and bug fixes. * Create a default implementation of IdsHolder and SyncedRegistrableRegistry. * Start working on wrapper for non-standard registry forms * Clean up and fix style * Fix missing events in MapRegistryWrapper * Avoid using sysout * Allow Synchronized Registry to declare themselves not to be synchronized * Allow setting the min id possible of a registry * Fix entry count in IdsHolder * SyncedArrayMapRegistryWrapper * Make Map+Array-based registry min id be 1 instead of 0 * SyncedArrayRegistryWrapper * RegistryWrapper Improvements * Fix defaulted registries default value not being interpreted as entry missing when it should. * Fix defaulted registries default value not being interpreted as entry missing when it should. (again) * Allow registering multiple entries together with a defined offset between their numerical ids. * Fix missing ids being taken over by new entries when entering an existing world * Fix style * Fix style and compiling errors * Disable complex registering for now * Clean up registry-sync-v1 * apache commons lang3 isn't available in 1.7.10 * Fix some parameter names * Add javadoc to deprecated classes and members * Rename some api classes/interfaces * Fix style * Small mixins clean-up * Document registry-sync-v2 apis + Add missing utility methods
* Block module rebase fixes * Fix whether to use neighbour light for Modded blocks * Clean up and fix style * Update test mods * Fix compiling errors * Spotless * Fix compiling errors * PR Feedback
* New "effect" module for Status Effects and Potions * Fix compiling errors due to renamed classes * 1.10 to 1.12.2 test mod for effects * 1.9.4 effect test mod * Fix 1.8.x effect api and add hooks to help registering potions * 1.8.x effect test mods * Make sure array based registries always have original array length be higher than the highest id in the registry to avoid IOOB errors when registering objects to it. * Fix effect translation key pre-1.9 * Port effect-api to 1.7.10 * 1.7.10 test mod * Fix compiling errors * Fix styling issues * Add helper methods to register Potion types and recipes * Add test effect and potion translation keys * Rename some variables to clarify the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New registry api, more extensible.
Individual registries for content are moved to their own module.
Saves and apis backward compatible with registry-sync-v1.
Modules