Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ More Storybook #75

Merged
merged 7 commits into from
Dec 9, 2024
Merged

✨ More Storybook #75

merged 7 commits into from
Dec 9, 2024

Conversation

caioaletroca
Copy link

Midaz Console Pull Request Checklist

Added stories for Skeleton, Separator, Command, Combobox and Collapsible.

Pull Request Type

  • UI
  • Core (Business Lógic)
  • Security
  • internationalization
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

Obs: Please, always remember to target your PR to develop branch instead of main.

@caioaletroca caioaletroca self-assigned this Dec 6, 2024
@caioaletroca caioaletroca added the enhancement New feature or request label Dec 6, 2024
@caioaletroca caioaletroca linked an issue Dec 6, 2024 that may be closed by this pull request
[FRONT] Add more components into Storybook #59
Open
@caioaletroca caioaletroca marked this pull request as ready for review December 6, 2024 16:33
paulofdev
paulofdev approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@paulofdev paulofdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@caioaletroca caioaletroca merged commit bb812ca into develop Dec 9, 2024
5 checks passed
@caioaletroca caioaletroca deleted the feature/storybook branch December 9, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augusto-draxx augusto-draxx augusto-draxx approved these changes

@paulofdev paulofdev paulofdev approved these changes

@gabrielcastr0 gabrielcastr0 Awaiting requested review from gabrielcastr0

Assignees

@caioaletroca caioaletroca

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FRONT] Add more components into Storybook
3 participants
@caioaletroca @paulofdev @augusto-draxx