Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/MIDAZ-288 #292

Merged
merged 42 commits into from
Nov 25, 2024
Merged

Feature/MIDAZ-288 #292

merged 42 commits into from
Nov 25, 2024

Conversation

MartinezAvellan
Copy link
Member

Midaz Pull Request Checklist

Pull Request Type

  • Auth
  • Infra
  • Ledger
  • Mdz
  • Transaction
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

Obs: Please, always remember to target your PR to develop branch instead of main.

qnen and others added 10 commits November 21, 2024 14:37
@qnen
fix: standardize telemetry and logger shutdown in ledger and transact…
d9246bf 
…ion services 🐛
@qnen
fix: update wire gen with standardize telemetry shutdown in ledger gr…
3cf681d 
…pc 🐛
@qnen
feat: add base to the swagger documentation and telemetry root span h…
0165a7c 
…andling for the swagger endpoint calls ✨
@qnen
chore: update codeowners group names 🔧
aaf0d29
@qnen
feat: update swagger documentation base using envs and generate docs …
7597ac2 
…in dockerfile ✨
@qnen
feat: add swagger documentation to onboarding context on ledger servi…
65ea499 
…ce ✨
@qnen
feat: add swagger documentation to the portfolio context on ledger se…
fad4b08 
…rvice ✨
@qnen
feat: add swagger documentation generated for ledger ✨
cef9e22
@MartinezAvellan
refactor: change ledger architecture 🔨
269b5c1
@MartinezAvellan
fix: make lint 🐛
1a2c76e
@MartinezAvellan MartinezAvellan added don't merge Don't merge this PR refactor Refactor the code domain:onboarding Responsible for the initial configuration of the ledger domain:portfolio Responsible for creating accounts labels Nov 22, 2024
@MartinezAvellan MartinezAvellan self-assigned this Nov 22, 2024
@MartinezAvellan MartinezAvellan linked an issue Nov 22, 2024 that may be closed by this pull request
Midaz change arch on LEDGER #288
Closed
lerian-studio-midaz-push-bot[bot]
lerian-studio-midaz-push-bot bot previously requested changes Nov 22, 2024
View reviewed changes
Copy link

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull requests to main can only come from develop or hotfix branches. Please change base!!!

@MartinezAvellan MartinezAvellan changed the base branch from main to develop November 22, 2024 19:30
@MartinezAvellan MartinezAvellan requested a review from a team November 22, 2024 19:35
@MartinezAvellan MartinezAvellan changed the title Feature/midaz 288 Feature/MIDAZ-288 Nov 22, 2024
@MartinezAvellan MartinezAvellan removed the don't merge Don't merge this PR label Nov 25, 2024
@MartinezAvellan MartinezAvellan added the don't merge Don't merge this PR label Nov 25, 2024
@MartinezAvellan MartinezAvellan removed the don't merge Don't merge this PR label Nov 25, 2024
@MartinezAvellan MartinezAvellan merged commit dcd6ea8 into develop Nov 25, 2024
5 checks passed
@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.29.0-beta.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwelbm maxwelbm maxwelbm approved these changes

@qnen qnen qnen approved these changes

@ClaraTersi ClaraTersi ClaraTersi approved these changes

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot[bot] lerian-studio-midaz-push-bot[bot] left review comments

Assignees

@MartinezAvellan MartinezAvellan

Labels
domain:onboarding Responsible for the initial configuration of the ledger domain:portfolio Responsible for creating accounts refactor Refactor the code released on @develop released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Midaz change arch on LEDGER
5 participants
@MartinezAvellan @ClaraTersi @qnen @maxwelbm @lerian-studio