Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/midaz 311 #312

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Fix/midaz 311 #312

merged 3 commits into from
Nov 26, 2024

Conversation

MartinezAvellan
Copy link
Member

@MartinezAvellan MartinezAvellan commented Nov 26, 2024 •
edited
Loading

Midaz Pull Request Checklist

Pull Request Type

  • Auth
  • Infra
  • Ledger
  • Mdz
  • Transaction
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

Obs: Please, always remember to target your PR to develop branch instead of main.

@MartinezAvellan MartinezAvellan changed the base branch from main to develop November 26, 2024 19:00
@MartinezAvellan MartinezAvellan requested a review from a team as a code owner November 26, 2024 19:00
lerian-studio-midaz-push-bot[bot]
lerian-studio-midaz-push-bot bot previously requested changes Nov 26, 2024
View reviewed changes
Copy link

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull requests to main can only come from develop or hotfix branches. Please change base!!!

@MartinezAvellan MartinezAvellan self-assigned this Nov 26, 2024
@MartinezAvellan MartinezAvellan added bug Something isn't working infra Infrastructure improvements and additions don't merge Don't merge this PR labels Nov 26, 2024
@MartinezAvellan MartinezAvellan linked an issue Nov 26, 2024 that may be closed by this pull request
Adjust git action version env #311
Closed
@MartinezAvellan MartinezAvellan merged commit 1b5b96f into develop Nov 26, 2024
6 checks passed
@lerian-studio-midaz-push-bot Lerian Studio Midaz Push Bot
Copy link

🎉 This PR is included in version 1.29.0-beta.20 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@lerian-studio-midaz-push-bot Lerian Studio Midaz Push Bot
Copy link

🎉 This PR is included in version 1.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClaraTersi ClaraTersi ClaraTersi approved these changes

@qnen qnen qnen approved these changes

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot[bot] lerian-studio-midaz-push-bot[bot] left review comments

Assignees

@MartinezAvellan MartinezAvellan

Labels
bug Something isn't working don't merge Don't merge this PR infra Infrastructure improvements and additions released on @develop released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust git action version env
4 participants
@MartinezAvellan @ClaraTersi @qnen @lerian-studio