Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/MIDAZ-358 #376

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

Feature/MIDAZ-358 #376

wants to merge 17 commits into from

Conversation

qnen
Copy link
Contributor

@qnen qnen commented Dec 11, 2024

Midaz Pull Request Checklist

Pull Request Type

  • Auth
  • Infra
  • Ledger
  • Mdz
  • Transaction
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

Obs: Please, always remember to target your PR to develop branch instead of main.

@qnen qnen added feature New feature domain:onboarding Responsible for the initial configuration of the ledger domain:portfolio Responsible for creating accounts domain:transactions Responsible for transactions and operations labels Dec 11, 2024
@qnen qnen self-assigned this Dec 11, 2024
@qnen qnen requested a review from a team as a code owner December 11, 2024 23:55
pkg/net/http/httputils.go Fixed Show fixed Hide fixed
pkg/net/http/httputils.go Fixed Show fixed Hide fixed
pkg/net/http/httputils.go Fixed Show fixed Hide fixed
pkg/utils.go Fixed Show resolved Hide resolved
qnen and others added 2 commits December 11, 2024 21:28
…ypes

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@qnen qnen linked an issue Dec 12, 2024 that may be closed by this pull request
Copy link

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golint

🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {


🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {


🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {


🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {


🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {


🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {


🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {


🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {


🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {


🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {


🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {

pkg/os.go Outdated Show resolved Hide resolved
pkg/os.go Outdated Show resolved Hide resolved
pkg/os.go Outdated Show resolved Hide resolved
pkg/os.go Outdated Show resolved Hide resolved
pkg/os.go Outdated Show resolved Hide resolved
pkg/os.go Outdated Show resolved Hide resolved
pkg/os.go Outdated Show resolved Hide resolved
pkg/os.go Outdated Show resolved Hide resolved
pkg/os.go Outdated Show resolved Hide resolved
pkg/os.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:onboarding Responsible for the initial configuration of the ledger domain:portfolio Responsible for creating accounts domain:transactions Responsible for transactions and operations feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement pagination rules
1 participant