added test id to button

LetsGetTechnical · Oct 10, 2024 · 1a7dd05 · 1a7dd05
1 parent 17269ec
commit 1a7dd05
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/components/AlertNotification/AlertNotification.test.tsx b/components/AlertNotification/AlertNotification.test.tsx
@@ -40,10 +40,14 @@ describe('AlertNotification', () => {
   }
   it('renders the dismiss button correctly', () => {
     render(
-      <Alert variant={AlertVariants.Success} message="test dismiss btn" />,
+      <Alert
+        variant={AlertVariants.Success}
+        message="test dismiss btn"
+        data-testid="dismiss-icon"
+      />,
     );
 
-    const dismissBtn = screen.getByTestId('dismiss-icon');
+    const dismissBtn = screen.getByTestId('dismiss-btn');
     expect(dismissBtn).toBeInTheDocument();
   });
 });
diff --git a/components/AlertNotification/AlertNotification.tsx b/components/AlertNotification/AlertNotification.tsx
@@ -50,11 +50,9 @@ const Alert = ({
       <Button
         variant="outline"
         className="absolute right-4 top-2 p-1 h-8 bg-transparent"
+        data-testid="dismiss-btn"
       >
-        <X
-          className="text-foreground h-full w-full"
-          data-testid="dismiss-icon"
-        />
+        <X className="text-foreground h-full w-full" />
       </Button>
     </AlertDefault>
   );