updated unit tests from #477 PR #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Gridiron Survivor Application
Project name: Gridiron Survivor Application
Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.
|
chris-nowicki
requested changes
Sep 24, 2024
utils/utils.ts
Outdated
| return ''; | ||
| } | ||
|
|
||
| const userSelectedTeam = NFLTeams.find((team) => team.teamName === userPick.teamName); |
There was a problem hiding this comment.
@vmaineng I still don't see this as resolved yet?
shashilo
requested changes
Oct 7, 2024
app/(main)/league/all/page.test.tsx
Outdated
| mockGetUserLeagues.mockResolvedValueOnce([]); | ||
| mockGetGameWeek.mockResolvedValueOnce({ week: 1 }); | ||
| render(<Leagues />); | ||
| test('should display GlobalSpinner while loading data', async () => { |
utils/utils.ts
Outdated
| return ''; | ||
| } | ||
|
|
||
| const userSelectedTeam = NFLTeams.find((team) => team.teamName === userPick.teamName); |
There was a problem hiding this comment.
Don't update the core functionality to get test to work. The test should be updated to match the core functionality.
shashilo
approved these changes
Oct 11, 2024
chris-nowicki
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related Issues/PRs
This is the PR that was submitted where tests were omitted to meet Alpha deadline.
- https://github.com/LetsGetTechnical/gridiron-survivor/issues/513