-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alex/Adjust table component columns #542
Conversation
Gridiron Survivor Application
Project name: Gridiron Survivor Application
Project name: Gridiron Survivor Application
Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…component-columns
…component-columns
…mns' into alex/adjust-table-component-columns
…component-columns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let the same comment for all of my comments, sorry about that.
Why is this being hardcoded in? Would it make more sense to make it a prop so we can reuse this? Or maybe I'm misunderstanding the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Closes #541
Created column variants for our different types of tables.
With this, it will be a simple component import and just have to and replace "leagueColumns" with the column type you want :)
These variants will be necessary for our admin dashboard.
NO TESTING NEEDED as testing was done for this in another ticket already resolved. The test itself tests that "column" data can be passed in. These column variants are just different column data to be passed in.