Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alex/Adjust table component columns #542

Merged
merged 12 commits into from
Oct 10, 2024

Conversation

alexappleget
Copy link
Contributor

@alexappleget alexappleget commented Sep 17, 2024

Closes #541

Created column variants for our different types of tables.

  1. League Columns
  2. League Details Columns
  3. Player Columns - would love suggestions for this

With this, it will be a simple component import and just have to and replace "leagueColumns" with the column type you want :)

These variants will be necessary for our admin dashboard.

NO TESTING NEEDED as testing was done for this in another ticket already resolved. The test itself tests that "column" data can be passed in. These column variants are just different column data to be passed in.

Copy link

appwrite bot commented Sep 17, 2024

Gridiron Survivor Application 6616ea581ef9f5521c7d

Function ID Status Action
Your function has been successfully deployed.

Project name: Gridiron Survivor Application
Project ID: 6616ea581ef9f5521c7d

Function ID Status Action
Update User Email 66e9e91800219e84e954 ready Ready View Logs
Your function has been successfully deployed.

Project name: Gridiron Survivor Application
Project ID: 6616ea581ef9f5521c7d

Function ID Status Action
userAuth 6626fef885a9f630442b ready Ready View Logs

Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.

💡 Did you know?
Appwrite has a Discord community with over 16 000 members. Come join us!

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gridiron-survivor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 9:30pm
gridiron-survivor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 9:30pm

Copy link
Member

@ryandotfurrer ryandotfurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let the same comment for all of my comments, sorry about that.

Why is this being hardcoded in? Would it make more sense to make it a prop so we can reuse this? Or maybe I'm misunderstanding the code.

components/TableColumns/TableColumns.tsx Show resolved Hide resolved
components/TableColumns/TableColumns.tsx Show resolved Hide resolved
components/TableColumns/TableColumns.tsx Show resolved Hide resolved
components/TableColumns/TableColumns.tsx Show resolved Hide resolved
components/TableColumns/TableColumns.tsx Show resolved Hide resolved
components/TableColumns/TableColumns.tsx Show resolved Hide resolved
components/TableColumns/TableColumns.tsx Show resolved Hide resolved
components/TableColumns/TableColumns.tsx Show resolved Hide resolved
components/TableColumns/TableColumns.tsx Show resolved Hide resolved
components/TableColumns/TableColumns.tsx Show resolved Hide resolved
Copy link
Member

@ryandotfurrer ryandotfurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@alexappleget alexappleget merged commit 3814e8d into develop Oct 10, 2024
5 checks passed
@alexappleget alexappleget deleted the alex/adjust-table-component-columns branch October 10, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust Table component columns
4 participants