Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Password reset email link (#556) #560

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Fix: Password reset email link (#556) #560

merged 3 commits into from
Sep 26, 2024

Conversation

chris-nowicki
Copy link
Contributor

fixes #556

@appwrite Appwrite
Copy link

appwrite bot commented Sep 23, 2024 •
edited
Loading

Gridiron Survivor Application 6616ea581ef9f5521c7d

Function ID Status Action
Your function deployment has failed. Please check the logs for more details and retry.

Project name: Gridiron Survivor Application
Project ID: 6616ea581ef9f5521c7d

Function ID Status Action
userAuth 6626fef885a9f630442b failed Failed View Logs

Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.

💡 Did you know?
You can use Avatars API to generate QR code for any text or URLs

@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gridiron-survivor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 3:11pm
gridiron-survivor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 3:11pm

choir241
choir241 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@choir241 choir241 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vmaineng
vmaineng approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@vmaineng vmaineng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for hardcoding the production email address to improve readability and simplify the code.

@shashilo shashilo merged commit 90add4a into develop Sep 26, 2024
5 checks passed
@shashilo shashilo deleted the chris/fix-email-reset-url branch September 26, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmaineng vmaineng vmaineng approved these changes

@choir241 choir241 choir241 approved these changes

@shashilo shashilo shashilo approved these changes

@mhchen mhchen Awaiting requested review from mhchen mhchen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FEE: Fix password reset email link
4 participants
@chris-nowicki @shashilo @choir241 @vmaineng