Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P-0: Disable Adding Entries #580

Merged
merged 2 commits into from
Oct 4, 2024
Merged

P-0: Disable Adding Entries #580

merged 2 commits into from
Oct 4, 2024

Conversation

choir241
Copy link
Contributor

What does this PR do?

disables add entries and remove related code for eslint rules and ignore realted tests
Fixes #579

Related screenshots/Videos

Screenshot 2024-09-30 123241

Related Issues/PRs

Have you spent some time to check if this issue has been raised before?

Have you Googled for a similar issue or checked our older issues?

  • I checked and didn't find similar issue *

@appwrite Appwrite
Copy link

appwrite bot commented Sep 30, 2024 •
edited
Loading

Gridiron Survivor Application 6616ea581ef9f5521c7d

Function ID Status Action
Your function deployment has failed. Please check the logs for more details and retry.

Project name: Gridiron Survivor Application
Project ID: 6616ea581ef9f5521c7d

Function ID Status Action
userAuth 6626fef885a9f630442b failed Failed View Logs

Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.

💡 Did you know?
Cursor pagination performs better than offset pagination when loading further pages

@vercel Vercel
Copy link

vercel bot commented Sep 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gridiron-survivor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 6:07pm
gridiron-survivor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 6:07pm

@choir241 choir241 changed the title Disable Adding Entries P-0: Disable Adding Entries Sep 30, 2024
ryandotfurrer
ryandotfurrer requested changes Sep 30, 2024
View reviewed changes
Copy link
Member

@ryandotfurrer ryandotfurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the ability add more entries, but I don't see anything that ensure all 5 entries are displayed for new users.

ryandotfurrer
ryandotfurrer approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@ryandotfurrer ryandotfurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

alexappleget
alexappleget approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@alexappleget alexappleget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shashilo shashilo enabled auto-merge (squash) October 4, 2024 18:07
@shashilo shashilo merged commit c7acabe into develop Oct 4, 2024
5 checks passed
@shashilo shashilo deleted the richard/disable-new-entries branch October 4, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shashilo shashilo shashilo approved these changes

@ryandotfurrer ryandotfurrer ryandotfurrer approved these changes

@alexappleget alexappleget alexappleget approved these changes

@mhchen mhchen Awaiting requested review from mhchen mhchen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P0 - Disable adding entries
4 participants
@choir241 @shashilo @ryandotfurrer @alexappleget