Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Danielle/550 remove past weeks picks link #583

Merged
merged 8 commits into from
Oct 8, 2024
Merged

Danielle/550 remove past weeks picks link #583

merged 8 commits into from
Oct 8, 2024

Conversation

Danielle254
Copy link
Contributor

Closes #550

Before
old

After
new

Also updated related tests. Did not see any issues with styling after removing Link element.

@appwrite Appwrite
Copy link

appwrite bot commented Oct 3, 2024 •
edited
Loading

Gridiron Survivor Application 6616ea581ef9f5521c7d

Function ID Status Action
Your function deployment has failed. Please check the logs for more details and retry.

Project name: Gridiron Survivor Application
Project ID: 6616ea581ef9f5521c7d

Function ID Status Action
userAuth 6626fef885a9f630442b failed Failed View Logs

Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.

💡 Did you know?
Appwrite has a Discord community with over 16 000 members. Come join us!

@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gridiron-survivor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 0:04am
gridiron-survivor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 0:04am

@Danielle254 Danielle254 force-pushed the danielle/550-remove-past-weeks-picks-link branch from 2dda998 to dd82da5 Compare October 6, 2024 13:48
@Danielle254
Copy link
Contributor Author

Danielle254 commented Oct 6, 2024 •
edited
Loading

Addressed merge conflicts. Ready for review.

@Danielle254 Danielle254 marked this pull request as ready for review October 6, 2024 13:50
choir241
choir241 requested changes Oct 6, 2024
View reviewed changes
app/(main)/league/[leagueId]/entry/all/page.tsx Outdated
@@ -194,20 +193,8 @@ const Entry = ({
/>
</section>
);
})}
})}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reverse this white space change please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@choir27 there should be no space or double the space?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@choir27 removed white space. let me know if that's not what you wanted.

@shashilo shashilo requested a review from choir241 October 7, 2024 03:44
@Danielle254 Danielle254 merged commit 76eefd5 into develop Oct 8, 2024
5 checks passed
@Danielle254 Danielle254 deleted the danielle/550-remove-past-weeks-picks-link branch October 8, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexappleget alexappleget alexappleget approved these changes

@choir241 choir241 choir241 approved these changes

@shashilo shashilo shashilo approved these changes

@mhchen mhchen Awaiting requested review from mhchen mhchen is a code owner

@ryandotfurrer ryandotfurrer Awaiting requested review from ryandotfurrer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: remove past week's picks link
4 participants
@Danielle254 @shashilo @choir241 @alexappleget