Shashi/disable game time #584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Re-Implement League Entries UI/UX Closes #443 My previous UI implementation was not carried over when the page was made interactive and filled with data, therefore, I had to re-implement it. ## Week 1 State  ## Week 2+ State If `currentWeek` is great than one, it should display a link to view past week's picks  ## To Do - [X] Double-check that my code is accurate to the design. - [X] Add tests.
fixes #496 ✅ Limits user to 5 entries ✅ Updated Unit Test ## SCREENSHOT 
Fixes #477 1) Fetched all leagues 2) allow user to select a league to join from the dropdown 3) add in success and error notifications 4) added in warning notifications of the same leagues have been selected already No tests are written as of the moment. --------- Co-authored-by: Alex Appleget <[email protected]> Co-authored-by: Chris Nowicki <[email protected]>
Close #315 * Set team if the user currently has them selected * Disable teams from being selected if they've already been used * Fix: only one team can be selected at a time --------- Co-authored-by: Shashi Lo <[email protected]> Co-authored-by: Mai Vang <[email protected]>
deleted space
…n-survivor into clue355/implement-menu-dropdown
|
Gridiron Survivor Application
Project name: Gridiron Survivor Application
Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
choir241
previously approved these changes
Oct 4, 2024
Comment on lines
+43
to
+44
| const timestampStr = gameTime; | ||
| const timestamp = new Date(timestampStr); |
There was a problem hiding this comment.
nit: I feel like this should just be new Date(gameTime), seems redundant to have timestampStr here.
Comment on lines
+47
to
+48
| // Subtract 1 hour from the current time | ||
| const currentTimeMinus1Hour = new Date( |
There was a problem hiding this comment.
nit: the function name is self-explanatory here, so the comment here is redundant
|
Incorrectly created feature branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.