Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cody/link to profile edit page #614

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Cody/link to profile edit page #614

merged 1 commit into from
Oct 22, 2024

Conversation

kepsteen
Copy link
Contributor

@kepsteen kepsteen commented Oct 17, 2024 •
edited
Loading

Closes #472

Branched off of Carlos's PR where he implement the user dropdown menu

  • added href="/account/settings" to edit profile link
  • Refactored the test to reflect the changes

@appwrite Appwrite
Copy link

appwrite bot commented Oct 17, 2024 •
edited
Loading

Gridiron Survivor Application 6616ea581ef9f5521c7d

Function ID Status Action
Your function deployment has failed. Please check the logs for more details and retry.

Project name: Gridiron Survivor Application
Project ID: 6616ea581ef9f5521c7d

Function ID Status Action
userAuth 6626fef885a9f630442b failed Failed View Logs

Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.

💡 Did you know?
Cursor pagination performs better than offset pagination when loading further pages

@vercel Vercel
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gridiron-survivor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 4:53pm
gridiron-survivor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 4:53pm

@kepsteen kepsteen requested a review from Clue355 October 17, 2024 16:54
@kepsteen kepsteen changed the title Cody/added href to edit profile dropdown Cody/link to profile edit page Oct 17, 2024
alexappleget
alexappleget approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@alexappleget alexappleget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ryandotfurrer
ryandotfurrer approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@ryandotfurrer ryandotfurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kepsteen kepsteen merged commit 843c317 into clue355/implement-menu-dropdown Oct 22, 2024
5 checks passed
@kepsteen kepsteen deleted the Cody/link-to-profile-edit-page branch October 22, 2024 18:57
@kepsteen kepsteen linked an issue Oct 22, 2024 that may be closed by this pull request
FEE: Connect User Dropdown Menu to Profile Edit Page #472
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexappleget alexappleget alexappleget approved these changes

@ryandotfurrer ryandotfurrer ryandotfurrer approved these changes

@shashilo shashilo shashilo approved these changes

@mhchen mhchen Awaiting requested review from mhchen

@Clue355 Clue355 Awaiting requested review from Clue355

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FEE: Connect User Dropdown Menu to Profile Edit Page
4 participants
@kepsteen @shashilo @ryandotfurrer @alexappleget