Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cody/fix getUserLeagues function #647

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Cody/fix getUserLeagues function #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4803767
change empty leagues check to array with empty string
kepsteen Oct 30, 2024
5735aa3
modify test for getUserLeagues
kepsteen Oct 30, 2024
24469d5
Merge branch 'develop' into Cody/fix-getUserLeagues
kepsteen Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions utils/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,14 +207,14 @@ describe('utils', () => {
});
});

xdescribe('getUserLeagues', () => {
describe('getUserLeagues', () => {
it('should return the list of leagues the user is a part of', async () => {
(getCurrentLeague as jest.Mock).mockResolvedValue(mockLeague);
const result = await getUserLeagues(mockUserData.leagues);
expect(result).toStrictEqual([mockLeague]);
});
it('should return an empty array if the user has no leagues', async () => {
const result = await getUserLeagues([]);
const result = await getUserLeagues(['']);
expect(getCurrentLeague).toHaveBeenCalledTimes(0);
expect(result).toStrictEqual([]);
});
Expand Down
2 changes: 1 addition & 1 deletion utils/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ export const parseUserPick = (
export const getUserLeagues = async (
leagues: IUser['leagues'],
): Promise<ILeague[]> => {
if (!leagues || leagues.length === 0) {
if (!leagues || leagues[0] === '') {
return [];
}
const userLeagues = leagues.map((league) => {
Expand Down