Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add True => 20 in process_frame_fast #99

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

matbryan52
Copy link
Member

Fixes missing default parameter conversion when using upsample = True and FastCorrelation.

Contributor Checklist:

@matbryan52 matbryan52 added the bug Something isn't working label Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.83%. Comparing base (208504f) to head (d7f1072).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   86.81%   86.83%   +0.02%     
==========================================
  Files          14       14              
  Lines        1191     1193       +2     
  Branches      171      172       +1     
==========================================
+ Hits         1034     1036       +2     
  Misses        105      105              
  Partials       52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sk1p sk1p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (before this change, the "sensible upsampling factor" for upsample=True was int(True) == 1)

@sk1p sk1p merged commit 9b5e229 into LiberTEM:master Jun 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants