Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fz holo #18

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fz holo #18

wants to merge 8 commits into from

Conversation

FENGSHAN95
Copy link

@FENGSHAN95 FENGSHAN95 commented Oct 30, 2020

Contributor Checklist:

  • I have added tests on phase_ramp

tests/test_holography.py Outdated Show resolved Hide resolved
@sk1p
Copy link
Member

sk1p commented Nov 2, 2020

The code is still not running - please see the output of the test runs, for example this one

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #18 (3c2d9d5) into master (43363eb) will increase coverage by 12.45%.
The diff coverage is 22.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #18       +/-   ##
===========================================
+ Coverage   39.28%   51.74%   +12.45%     
===========================================
  Files           8        8               
  Lines         168      172        +4     
  Branches       15       17        +2     
===========================================
+ Hits           66       89       +23     
+ Misses         97       74       -23     
- Partials        5        9        +4     
Impacted Files Coverage Δ
src/libertem_holo/base/filters.py 50.00% <22.22%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43363eb...3c2d9d5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants