Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Android 12 #315

Merged
merged 6 commits into from
May 22, 2022
Merged

Update to Android 12 #315

merged 6 commits into from
May 22, 2022

Conversation

AdamNiederer
Copy link
Collaborator

@AdamNiederer AdamNiederer commented Apr 24, 2022 •
edited
Loading

  1. Pulls in KPreferences and removes jcenter
  2. Add FLAG_IMMUTABLE and exported to everything
  3. Requests SCHEDULE_EXACT_ALARM permissions on Android 12
  4. Prevent a crash when scheduling the overlay, caused by some new requirements of foreground services in Android 12

This fixes all of the build errors and crashes related to the new API level - I've tested it on Android 12 and Android 7.

@smichel17
Copy link
Member

Thank you! I'll take a look at this and try to get a release out this weekend

smichel17
smichel17 reviewed May 8, 2022
View reviewed changes
Copy link
Member

@smichel17 smichel17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few questions about things I'd like to understand before merging. The comments/suggestions are pretty minor, and you can either act on them or just resolve them.

app/build.gradle Show resolved Hide resolved
app/build.gradle Show resolved Hide resolved
app/src/main/java/com/jmstudios/redmoon/KPreferences.kt Show resolved Hide resolved
app/src/main/java/com/jmstudios/redmoon/preference/ProfileSelectorPreference.kt Outdated Show resolved Hide resolved
build.gradle Show resolved Hide resolved
.github/workflows/android.yml Show resolved Hide resolved
app/src/main/java/com/jmstudios/redmoon/Command.kt Show resolved Hide resolved
@smichel17
Copy link
Member

smichel17 commented May 22, 2022 •
edited
Loading

I tested this in an emulator, and unfortunately it did not fix #309; the overlay still absorbs taps when in any app besides Red Moon itself. I suppose you didn't mention that issue here, so maybe this was just a general update, not a fix for that?

@smichel17
Copy link
Member

Well, it fixes the build anyway, so I'm going to merge, and if you intended this to fix #309, you can send a follow-up PR.

@smichel17 smichel17 merged commit 5e4158c into LibreShift:master May 22, 2022
@AdamNiederer
Copy link
Collaborator Author

Sorry, totally forgot to follow up on these reviews; thanks for helping it over the finish line. #309 will most likely need an accessibility overlay, although I've had issues getting it to work as outlined in that issue.

@AdamNiederer
Copy link
Collaborator Author

I will probably be forced to buy a new phone soon (thanks Sprint!), so this PR was getting most of the grunt work out of the way in preparation for figuring out #309; hopefully having my eyes seared at night will be sufficient motivation.

@smichel17
Copy link
Member

Ha— I'm still running 7.0 (thanks Samsung+AT&T!) so I've been a little lacking on the motivation front lately. Also I've started putting my phone away at night entirely, so it's not as big of an issue for me any more.

@smichel17 smichel17 added this to the next release milestone Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smichel17 smichel17 smichel17 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamNiederer @smichel17