-
Notifications
You must be signed in to change notification settings - Fork 12
Iterating through addresses matching a signature #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jujstme
wants to merge
15
commits into
LiveSplit:master
Choose a base branch
from
Jujstme:fix_sigscan
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
030b767
Allow signature scanning to cross page boundaries
Jujstme 8af2c3e
Fix
Jujstme d722877
Reimplemented to return an iterator
Jujstme ca2e5f3
Merge branch 'master' into fix_sigscan
Jujstme da55c6c
Reimplemented use of ranges in the scan method
Jujstme ccdd087
Merge branch 'master' into fix_sigscan
Jujstme d344ec0
Fixed code according to the suggestions provided
Jujstme a6b7c36
Refactored
Jujstme cda9fef
cargo fmt
Jujstme 16f7e38
fix
Jujstme 96c4fb8
Fixed MaybeUninit causing issues
Jujstme 948b6ea
Merge branch 'master' into fix_sigscan
Jujstme 1b0d746
Final touch ups
Jujstme abe8daf
Forgot cfg directive
Jujstme 25bd8de
Merge branch 'master' into fix_sigscan
Jujstme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this returning 'a?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uhhh it really shouldn't. Probably leftover data or clippy lints that stayed behind. Weird, I admit lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ok I know now. Clippy complains because the lifetime is known to be 'a, so there's no reason to elide it.