Replace img_hash dependency
#725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CryZe
added
enhancement
CryZe
force-pushed
the
replace-img-hash
branch
from
4a993ef
to
576f48a
Compare
While a visual hash is a good idea, the underlying `tiny-skia` is meant to pixel perfectly match `Skia`. This means that our hash doesn't actually need to be visual and can be a simple checksum. The `img_hash` crate is very unmaintained, so we are forced to compile ever more so outdated dependencies. So replacing it by a simple checksum via the `seahash` crate makes a lot of sense. The `seahash` crate claims to be very fast and also claims that the hashes are suitable for checksums. So it sounds like a good crate to use for this. However this means that on platforms that don't correctly implement IEEE-754, we can't run the rendering tests anymore. However when it comes to font fallback, it does seem like there's some changes between Windows 10 and 11, so we do need to differentiate between those now.
CryZe
force-pushed
the
replace-img-hash
branch
from
576f48a
to
5d93732
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While a visual hash is a good idea, the underlying
tiny-skiais meant to pixel perfectly matchSkia. This means that our hash doesn't actually need to be visual and can be a simple checksum. Theimg_hashcrate is very unmaintained, so we are forced to compile ever more so outdated dependencies. So replacing it by a simple checksum via theseahashcrate makes a lot of sense. Theseahashcrate claims to be very fast and also claims that the hashes are suitable for checksums. So it sounds like a good crate to use for this. However this means that on platforms that don't correctly implement IEEE-754, we can't run the rendering tests anymore.