Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(macos): fix libcurl linking #3383

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Nov 9, 2024

Description

libcurl is no longer linking properly on macOS under homebrew.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher force-pushed the build/macos/fix-libcurl-linking branch 2 times, most recently from 11c0d7a to d8f6ad2 Compare November 9, 2024 20:07
@ReenigneArcher ReenigneArcher force-pushed the build/macos/fix-libcurl-linking branch from d8f6ad2 to be3706c Compare November 9, 2024 20:07
Copy link

sonarcloud bot commented Nov 9, 2024

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.16%. Comparing base (fb1f5b5) to head (be3706c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3383      +/-   ##
==========================================
+ Coverage   10.90%   11.16%   +0.26%     
==========================================
  Files          99       99              
  Lines       17247    17253       +6     
  Branches     8044     8045       +1     
==========================================
+ Hits         1880     1927      +47     
+ Misses      14586    14539      -47     
- Partials      781      787       +6     
Flag Coverage Δ
Linux 8.43% <ø> (+0.06%) ⬆️
Windows 5.31% <ø> (ø)
macOS-13 13.62% <ø> (ø)
macOS-14 12.65% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 19 files with indirect coverage changes

@ReenigneArcher ReenigneArcher marked this pull request as ready for review November 9, 2024 20:32
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) November 9, 2024 20:32
@ReenigneArcher ReenigneArcher merged commit d1e7865 into master Nov 9, 2024
36 checks passed
@ReenigneArcher ReenigneArcher deleted the build/macos/fix-libcurl-linking branch November 9, 2024 21:02
@raye-deng
Copy link

`==> Fetching lizardbyte/homebrew/sunshine-beta
==> Cloning https://github.com/LizardByte/Sunshine.git
Updating /Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git
==> Checking out tag v2024.1109.210203
HEAD is now at d1e7865 build(macos): fix libcurl linking (#3383)
HEAD is now at d1e7865 build(macos): fix libcurl linking (#3383)
Entering 'packaging/linux/flatpak/deps/flatpak-builder-tools'
Entering 'packaging/linux/flatpak/deps/shared-modules'
Entering 'third-party/Simple-Web-Server'
Entering 'third-party/TPCircularBuffer'
Entering 'third-party/ViGEmClient'
Entering 'third-party/build-deps'
Entering 'third-party/doxyconfig'
Synchronizing submodule url for 'doxygen-awesome-css'
Entering 'third-party/doxyconfig/doxygen-awesome-css'
Entering 'third-party/googletest'
Entering 'third-party/inputtino'
Entering 'third-party/moonlight-common-c'
Synchronizing submodule url for 'enet'
Entering 'third-party/moonlight-common-c/enet'
Entering 'third-party/nanors'
Entering 'third-party/nv-codec-headers'
Entering 'third-party/nvapi-open-source-sdk'
Entering 'third-party/tray'
Synchronizing submodule url for 'third-party/doxyconfig'
Synchronizing submodule url for 'third-party/googletest'
Entering 'third-party/tray/third-party/doxyconfig'
Synchronizing submodule url for 'doxygen-awesome-css'
Entering 'third-party/tray/third-party/doxyconfig/doxygen-awesome-css'
Entering 'third-party/tray/third-party/googletest'
Entering 'third-party/wayland-protocols'
Entering 'third-party/wlr-protocols'
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/packaging/linux/flatpak/deps/flatpak-builder-tools
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/packaging/linux/flatpak/deps/shared-modules
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/third-party/Simple-Web-Server
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/third-party/TPCircularBuffer
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/third-party/ViGEmClient
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/third-party/build-deps
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/third-party/doxyconfig
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/third-party/doxyconfig/doxygen-awesome-css
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/third-party/googletest
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/third-party/inputtino
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/third-party/moonlight-common-c
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/third-party/moonlight-common-c/enet
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/third-party/nanors
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/third-party/nv-codec-headers
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/third-party/nvapi-open-source-sdk
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/third-party/tray
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/third-party/tray/third-party/doxyconfig
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/third-party/tray/third-party/doxyconfig/doxygen-awesome-css
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/third-party/tray/third-party/googletest
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/third-party/wayland-protocols
/Users/raye.deng/Library/Caches/Homebrew/sunshine-beta--git/third-party/wlr-protocols
==> Installing sunshine-beta from lizardbyte/homebrew
==> Building docs: disabled
==> Disabled statically linking Boost libraries
==> cmake -S . -B build -DBUILD_WERROR=ON -DHOMEBREW_ALLOW_FETCHCONTENT=ON -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl@3 -DSUNSHINE_ASSETS_DIR=sunshine/assets -DSUNSHINE_
Last 15 lines from /Users/raye.deng/Library/Logs/Homebrew/sunshine-beta/01.cmake:
-- Found PkgConfig: /usr/local/bin/pkg-config (found version "0.29.2")
-- Checking for module 'libcurl'
-- Package 'mit-krb5-gssapi', required by 'libcurl', not found
CMake Error at /usr/local/opt/cmake/share/cmake/Modules/FindPkgConfig.cmake:645 (message):
The following required packages were not found:

  • libcurl

Call Stack (most recent call first):
/usr/local/opt/cmake/share/cmake/Modules/FindPkgConfig.cmake:873 (_pkg_check_modules_internal)
cmake/dependencies/common.cmake:19 (pkg_check_modules)
CMakeLists.txt:54 (include)

-- Configuring incomplete, errors occurred!

If reporting this issue please do so at (not Homebrew/brew or Homebrew/homebrew-core):
https://github.com/lizardbyte/homebrew-homebrew/issues`

still in 15.1 Beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants