Skip to content

Commit

Permalink
fix: cloudbuild trigger SA roles (#1899)
Browse files Browse the repository at this point in the history
* chore: move .dev.env.enc to correct location

* chore: add cloud build service agent to cloud build trigger SA, update staging secret

* chore: fix tests
  • Loading branch information
Ziinc authored Dec 29, 2023
1 parent f3277b5 commit beff28f
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 0 deletions.
File renamed without changes.
Binary file modified cloudbuild/.staging.env.enc
Binary file not shown.
4 changes: 4 additions & 0 deletions lib/logflare/google/resource_manager.ex
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,10 @@ defmodule Logflare.Google.CloudResourceManager do
%Model.Binding{
members: ["serviceAccount:#{env_cloud_build_trigger_sa()}"],
role: "roles/iam.serviceAccountUser"
},
%Model.Binding{
members: ["serviceAccount:#{env_cloud_build_trigger_sa()}"],
role: "roles/cloudbuild.serviceAgent"
}
]
end
Expand Down
4 changes: 4 additions & 0 deletions test/logflare/google/resource_manager_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,10 @@ defmodule Logflare.Google.CloudResourceManagerTest do
%Binding{
members: ["serviceAccount:#{google_configs.cloud_build_trigger_sa}"],
role: "roles/iam.serviceAccountUser"
},
%Binding{
members: ["serviceAccount:#{google_configs.cloud_build_trigger_sa}"],
role: "roles/cloudbuild.serviceAgent"
}
]
end
Expand Down

0 comments on commit beff28f

Please sign in to comment.