Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ft: BigQuery backend adaptor #1833

Merged
merged 1 commit into from
Dec 12, 2023
Merged

ft: BigQuery backend adaptor #1833

merged 1 commit into from
Dec 12, 2023

Conversation

hauleth
Copy link
Contributor

@hauleth hauleth commented Nov 20, 2023

No description provided.

@hauleth hauleth self-assigned this Nov 20, 2023
@hauleth hauleth force-pushed the ft/big-query-backend-adaptor branch 5 times, most recently from 705fbb5 to cbc3ac5 Compare November 24, 2023 10:41
@hauleth hauleth force-pushed the ft/big-query-backend-adaptor branch 3 times, most recently from 7552972 to 04cceda Compare November 30, 2023 15:02
@hauleth hauleth force-pushed the ft/big-query-backend-adaptor branch from 04cceda to 5b80555 Compare December 8, 2023 12:40
@hauleth hauleth marked this pull request as ready for review December 8, 2023 12:41
@hauleth hauleth force-pushed the ft/big-query-backend-adaptor branch from 5b80555 to 65beb29 Compare December 8, 2023 12:50
Copy link
Contributor

@Ziinc Ziinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits, looks great 👍

lib/logflare/backends/adaptor/bigquery_adaptor.ex Outdated Show resolved Hide resolved
lib/logflare/backends/adaptor/bigquery_adaptor.ex Outdated Show resolved Hide resolved
lib/logflare/backends/source_backend.ex Outdated Show resolved Hide resolved
@hauleth hauleth force-pushed the ft/big-query-backend-adaptor branch 2 times, most recently from 8a662f3 to baea2e3 Compare December 12, 2023 17:27
- change specs so the success type is on the left
- add additional callback to adaptors

  All adaptors are currently backed by the process, so to simplify
  operation of these backends this commit move the responsibility for
  defining child spec to the behaviour instead of
  `Logflare.Backends.SourceBackend`.

- add BigQuery to list of supported adaptors
- reuse existing BigQuery pipeline
@hauleth hauleth force-pushed the ft/big-query-backend-adaptor branch from baea2e3 to ac8a580 Compare December 12, 2023 18:09
@hauleth hauleth merged commit 73bfa10 into main Dec 12, 2023
2 checks passed
@hauleth hauleth deleted the ft/big-query-backend-adaptor branch December 12, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants