Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicAperture Softening parameter is dependent on the pixel scale #224

Closed
LouisDesdoigts opened this issue Apr 20, 2023 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@LouisDesdoigts
Copy link
Owner

The softening parameter is meant to be agnostic to the physical scale of the aperture itself, but this is not the case.

Example:

import dLux as dl
import matplotlib.pyplot as plt

radius = 1e-6
aper = dl.CircularAperture(1e-6)
plt.imshow(aper.get_transmission(256, 2*radius))

Screenshot 2023-04-20 at 1 50 19 pm

We need to set softening to a very small value to get sensible results

aper = dl.CircularAperture(1e-6, softening=1e-5)
plt.imshow(aper.get_transmission(256, 2*radius))

Screenshot 2023-04-20 at 1 51 21 pm

This will be an issue for coronagraphs that have small angular pixel scales in the occulter plane.


@LouisDesdoigts LouisDesdoigts added the bug Something isn't working label Apr 20, 2023
@LouisDesdoigts LouisDesdoigts self-assigned this Apr 20, 2023
@LouisDesdoigts
Copy link
Owner Author

@Jordan-Dennis would love your thoughts. I briefly tried to add a scale parameter to the _soften method taken from the coordinates but it seems the solution will be a little more involved than that.

@LouisDesdoigts
Copy link
Owner Author

Fixed with #246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants