pull broker only takes 2 params. #639
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettelliot
had a problem deploying
to
unit-tests
GitHub Actions
Failure
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| lumibot/components/drift_rebalancer_logic.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ✅ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
|
Hay guys, how do i stop recieving eamils from you chats on github? im
getting a ton of messages aevery day.
…On Wed, Nov 27, 2024 at 12:08 PM korbit-ai[bot] ***@***.***> wrote:
***@***.***[bot]* commented on this pull request.
I've completed my review and didn't find any issues.
Files scanned
File Path Reviewed
lumibot/components/drift_rebalancer_logic.py ✅
Explore our documentation <https://docs.korbit.ai> to understand the
languages and file types we support
<https://docs.korbit.ai/configuration/supported-languages> and the files
we ignore <https://docs.korbit.ai/configuration/ignoring-files>.
Need a new review? Comment /korbit-review on this PR and I'll review your
latest changes.
Korbit Guide: Usage and Customization Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-review command in a comment at the root of your PR.
- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-description command in any comment on your PR.
- Too many Korbit comments? I can resolve all my comment threads if
you use the /korbit-resolve command in any comment on your PR.
- Chat with Korbit on issues we post by tagging @korbit-ai
<https://github.com/korbit-ai> in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on
the comments Korbit posts.
Customizing Korbit
- Check out our docs
<https://docs.korbit.ai/configuration/organization-settings> on how
you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console
<https://app.korbit.ai/a18b7e63-743d-4f50-b9b5-cb58f1beb0f3/settings>.
Current Korbit Configuration General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions ✅ Issue Categories
Category Enabled
Naming ✅
Database Operations ✅
Documentation ✅
Logging ✅
Error Handling ✅
Systems and Environment ✅
Objects and Data Structures ✅
Readability and Maintainability ✅
Asynchronous Processing ✅
Design Patterns ✅
Third-Party Libraries ✅
Performance ✅
Security ✅
Functionality ✅ Feedback and Support
- Tell us what you think of Korbit
<https://rfn13ctpmt0.typeform.com/to/DOoeLyoN>
- Schedule a call with our team
<https://meetings.salesloft.com/korbittechnologies/korbitai>
- Email us @ ***@***.***
—
Reply to this email directly, view it on GitHub
<#639 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIOKVG4EGXXXITYHGKFIYS32CWRZTAVCNFSM6AAAAABSSSFJ3SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINRUG4YDONJTGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
@Syntax-Sorcerer87 I am looking at your pull request. The description will be updated shortly. In the meantime, please do not edit the description until I have finished writing mine. |
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| lumibot/components/drift_rebalancer_logic.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ✅ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
|
Dude, i dont know waht i did, i am a tottal noob on github, i want to stop
recieving eamils about this stuff. please!
…On Wed, Nov 27, 2024 at 2:30 PM korbit-ai[bot] ***@***.***> wrote:
@Syntax-Sorcerer87 <https://github.com/Syntax-Sorcerer87> I am looking at
your pull request. The description will be updated shortly. In the
meantime, please do not edit the description until I have finished writing
mine.
—
Reply to this email directly, view it on GitHub
<#639 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIOKVGYNM2LA2CYVJHEKVUT2CXCPDAVCNFSM6AAAAABSSSFJ3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBTHA4DIMJVHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
*Hi *Syntax-Sorcerer87,
There's an unsubscribe link in all the emails.
*Brett Elliot*
On Wed, Nov 27, 2024 at 8:36 AM Syntax-Sorcerer87 ***@***.***>
wrote:
… Dude, i dont know waht i did, i am a tottal noob on github, i want to stop
recieving eamils about this stuff. please!
On Wed, Nov 27, 2024 at 2:30 PM korbit-ai[bot] ***@***.***>
wrote:
> @Syntax-Sorcerer87 <https://github.com/Syntax-Sorcerer87> I am looking
at
> your pull request. The description will be updated shortly. In the
> meantime, please do not edit the description until I have finished
writing
> mine.
>
> —
> Reply to this email directly, view it on GitHub
> <#639 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/BIOKVGYNM2LA2CYVJHEKVUT2CXCPDAVCNFSM6AAAAABSSSFJ3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBTHA4DIMJVHE>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#639 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACLNB4M2UXKXU2G7WGSFW232CXDF5AVCNFSM6AAAAABSSSFJ3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBTHA4TOMZXG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description by Korbit AI
What change is being made?
Modify the
_pull_ordermethod calls within the_rebalancefunction to accept only two parameters instead of three.Why are these changes being made?
The third parameter,
self.strategy, was deemed redundant for the_pull_ordermethod invocation, as the necessary context can be derived from the remaining parameters. This simplifies the code and aligns with any updates in the underlying method definitions.