Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove substitution #385

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Remove substitution #385

merged 1 commit into from
Sep 26, 2024

Conversation

mhmohona
Copy link
Contributor

@mhmohona mhmohona commented Sep 26, 2024 •
edited
Loading

Removed substitution, which was occurring because there was multiple images with the same alt text no_overlap_view.

Closes: #376

📚 Documentation preview 📚: https://mdanalysisuserguide--385.org.readthedocs.build/en/385/

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

RMeli
RMeli approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mhmohona, the error no longer shows up in CI. Keep up the good work!

@RMeli RMeli merged commit 406f84d into MDAnalysis:develop Sep 26, 2024
5 checks passed
@mhmohona mhmohona deleted the substitution branch October 13, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMeli RMeli RMeli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate substitution definition name
2 participants
@mhmohona @RMeli