Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not fetch users associated objects recursive for audit logging #10267

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

Benni0
Copy link
Contributor

@Benni0 Benni0 commented Mar 20, 2025

What does it do?

Currently users are fetched with all associated events for audit logging, but only org_id is used.
If the user is associated with many events, this might take much time.
If only the user instance, without associated objects is fetched, audit logging is much faster.

If it fixes an existing issue, please use github syntax: #10264

Questions

  • Does it require a DB change?
  • Are you using it in production?
  • Does it require a change in the API (PyMISP for example)?

@Benni0 Benni0 marked this pull request as ready for review March 20, 2025 08:42
@Benni0 Benni0 changed the title fix: Do not fetch user recursive for audit logging fix: Do not fetch users associated objects recursive for audit logging Mar 20, 2025
@adulau adulau requested a review from iglocska March 20, 2025 21:42
@iglocska iglocska merged commit a57c14a into MISP:2.5 Mar 26, 2025
2 checks passed
@iglocska
Copy link
Member

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants