Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slight modification to lnk object for additional usecases #451

Merged
merged 5 commits into from
Feb 11, 2025

Conversation

mgreen27
Copy link
Contributor

@mgreen27 mgreen27 commented Feb 11, 2025

Im not sure the protocol but I changed the GUID on the object, happy to change back if the usual protocol is to keep it when updating an object.

Allowing multiple text fields allows for additional data such as base64 decoded cli and other summary data we use as needed.

Added a 2 more fields:
lnk-mft-object - LinkTargetIDList MFT entry. Name:MFTID|SeqID|<BTimestamp>
lnk-propertystore-sid - SID reference in ExtraData.PropertyStore

@adulau
Copy link
Member

adulau commented Feb 11, 2025

Thanks a lot for the proposal.

I'll update it a bit to keep the original UUID (keep UUID for object template). For the original data in Base64, should we have a new field ? is it something standard which could be reused by others ?

@adulau adulau self-assigned this Feb 11, 2025
@mgreen27
Copy link
Contributor Author

No worries - I ended up comiting the original UUID as I noticed the test failed.
We use the text attribute field for base64 and for an attribute summary so making it a multiple was the main use for us.
If you think a specific b64cli field is more valuable we can add that too, but im happy with just making the text field multi capable as that fits our needs.

@adulau adulau merged commit 904128f into MISP:main Feb 11, 2025
2 of 5 checks passed
@adulau
Copy link
Member

adulau commented Feb 11, 2025

All good. I merged it and made a quick fix to the JSON version. We can expand it later if we see more digital forensic analysts adding data to shared objects.

Thanks a lot for the contribution. If you see other object templates to updates, don't hesitate.

It will be by default in the next version of MISP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants