Additional play display compatibility #548
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WardBrian
requested changes
Aug 3, 2024
| @@ -45,6 +45,7 @@ def __init__(self, game_id, date, broadcasts, series_status, delay_in_10s_of_sec | |||
| self._broadcasts = broadcasts | |||
| self._series_status = series_status | |||
| self._status = {} | |||
| print(self.game_id) | |||
There was a problem hiding this comment.
Suggested change
| print(self.game_id) |
Comment on lines
+319
to
+337
| "flies" | ||
| in self._current_data["liveData"]["plays"].get("currentPlay", {}).get("result", {}).get("description", "") | ||
| ): | ||
| result += "_fly" | ||
| elif result == "field_out" and ( | ||
| "grounds" | ||
| in self._current_data["liveData"]["plays"].get("currentPlay", {}).get("result", {}).get("description", "") | ||
| ): | ||
| result += "_ground" | ||
| elif result == "field_out" and ( | ||
| "lines" | ||
| in self._current_data["liveData"]["plays"].get("currentPlay", {}).get("result", {}).get("description", "") | ||
| ): | ||
| result += "_line" | ||
| elif result == "field_out" and ( | ||
| "pop" | ||
| in self._current_data["liveData"]["plays"].get("currentPlay", {}).get("result", {}).get("description", "") | ||
| ): | ||
| result += "_pop" |
There was a problem hiding this comment.
I think it would make sense to turn this into a helper function called like out_type
Comment on lines
+338
to
+400
| elif result == "field_out" and ( | ||
| "scores" | ||
| in self._current_data["liveData"]["plays"].get("currentPlay", {}).get("result", {}).get("description", "") | ||
| ): | ||
| result += "_rbi" | ||
|
|
||
| if result == "field_out_fly" and ( | ||
| "scores" | ||
| in self._current_data["liveData"]["plays"].get("currentPlay", {}).get("result", {}).get("description", "") | ||
| ): | ||
| result += "_rbi" | ||
| elif result == "field_out_ground" and ( | ||
| "scores" | ||
| in self._current_data["liveData"]["plays"].get("currentPlay", {}).get("result", {}).get("description", "") | ||
| ): | ||
| result += "_rbi" | ||
| elif result == "field_out_line" and ( | ||
| "scores" | ||
| in self._current_data["liveData"]["plays"].get("currentPlay", {}).get("result", {}).get("description", "") | ||
| ): | ||
| result += "_rbi" | ||
| elif result == "field_out_pop" and ( | ||
| "scores" | ||
| in self._current_data["liveData"]["plays"].get("currentPlay", {}).get("result", {}).get("description", "") | ||
| ): | ||
| result += "_rbi" | ||
|
|
||
| if result == "sacrifice_fly" and ( | ||
| "scores" | ||
| in self._current_data["liveData"]["plays"].get("currentPlay", {}).get("result", {}).get("description", "") | ||
| ): | ||
| result += "_rbi" | ||
| elif result == "sacrifice_bunt" and ( | ||
| "scores" | ||
| in self._current_data["liveData"]["plays"].get("currentPlay", {}).get("result", {}).get("description", "") | ||
| ): | ||
| result += "_rbi" | ||
|
|
||
| if result == "single" and ( | ||
| "scores" | ||
| in self._current_data["liveData"]["plays"].get("currentPlay", {}).get("result", {}).get("description", "") | ||
| ): | ||
| result += "_rbi" | ||
| elif result == "double" and ( | ||
| "scores" | ||
| in self._current_data["liveData"]["plays"].get("currentPlay", {}).get("result", {}).get("description", "") | ||
| ): | ||
| result += "_rbi" | ||
| elif result == "triple" and ( | ||
| "scores" | ||
| in self._current_data["liveData"]["plays"].get("currentPlay", {}).get("result", {}).get("description", "") | ||
| ): | ||
| result += "_rbi" | ||
| elif result == "walk" and ( | ||
| "scores" | ||
| in self._current_data["liveData"]["plays"].get("currentPlay", {}).get("result", {}).get("description", "") | ||
| ): | ||
| result += "_rbi" | ||
| elif result == "hit_by_pitch" and ( | ||
| "scores" | ||
| in self._current_data["liveData"]["plays"].get("currentPlay", {}).get("result", {}).get("description", "") | ||
| ): | ||
| result += "_rbi" |
There was a problem hiding this comment.
Similarly, I think making a helper function called "did_score" or something could simplify this
|
Thanks for the detailed thoughts (some of which made me facepalm)! I'll revise accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes changes in data/plays.py and data/game.py to add compatibility with numerous other common plays in the scoreboard. This could be combined with changes in renderers/game/game.py to display many more play results on scoreboards (as I've done with the rest of the code on my personal repository).
Specifically:
All original plays and abbreviations should have been maintained and not break any existing functionality.
(I don't know what I'm doing, so please provide feedback if going about this incorrectly)