Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Added Simplified Chinese language pack #220

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

JeremyGolf70
Copy link
Contributor

@JeremyGolf70 JeremyGolf70 commented Dec 14, 2020

Relates to #183

Description

The Simplified Chinese language pack is added. This translation is composed by JeremyGolf70 (a.k.a. 空中黑客).

Some terms remain unchanged in English to make it easy to recognize in certain situations. Some strings have been rewritten in Chinese to make it easier to understand.

Time format is not perfect since I have no method to change Mon/Tue/Wed etc. to 星期一/星期二/星期三 etc.
I have no method to change AM/PM to 上午/下午 either.

Review focus

Checklist

  • I have run yarn format
  • I have run yarn eslint and fixed any issues
  • This PR does not add any errors to the console
  • I have added this change to the changelog

A build will automatically be run by GitHub actions when any changes are made on this PR. This must complete successfully before merging.

Screenshots or videos

Click to expand

@davwheat davwheat merged commit ec33b27 into MSFS-Mega-Pack:main Dec 15, 2020
@davwheat
Copy link
Member

davwheat commented Dec 15, 2020

GitHub got super messed up with this PR... I have no clue what is going on, but merging with GitKraken worked fine?

Thanks for your hard work @JeremyGolf70!

@davwheat
Copy link
Member

Hey @JeremyGolf70, I fixed the issue with AM/PM and days of the week.

What would be the most common way of writing dates and times in Chinese? Would you use AM/PM and days of the week, or just use YYYY-MM-DD HH:mm?

@JeremyGolf70
Copy link
Contributor Author

JeremyGolf70 commented Dec 16, 2020 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants